Skip to content

Add metadata retrieved from the context to the user agent when a new HTTP client is created #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Add metadata retrieved from the context to the user agent when a new HTTP client is created #2789

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7b5399
Set the extra user agent when a new rpc instance is created
MatteoPologruto Jan 16, 2025
fe84afb
Add integration test
MatteoPologruto Jan 22, 2025
4f73e4c
Moved user-agent extraction deep in configuration.HttpClient
cmaglie Jan 22, 2025
fc6d0a6
Updated integration test
cmaglie Jan 22, 2025
527f7d2
Restore previous user-agent for package manager
cmaglie Jan 22, 2025
2e7d6c2
Apply review suggestions to the integration test
MatteoPologruto Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restore previous user-agent for package manager
  • Loading branch information
@cmaglie
cmaglie committed Jan 22, 2025
commit 527f7d2568388bcfe6fa63b1126aa3467d3e76dd
8 changes: 7 additions & 1 deletion commands/instances.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import (
paths "github.com/arduino/go-paths-helper"
"github.com/sirupsen/logrus"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/metadata"
"google.golang.org/grpc/status"
)

Expand All @@ -63,6 +64,11 @@ func installTool(ctx context.Context, pm *packagemanager.PackageManager, tool *c

// Create a new Instance ready to be initialized, supporting directories are also created.
func (s *arduinoCoreServerImpl) Create(ctx context.Context, req *rpc.CreateRequest) (*rpc.CreateResponse, error) {
var userAgent string
if md, ok := metadata.FromIncomingContext(ctx); ok {
userAgent = strings.Join(md.Get("user-agent"), " ")
}

// Setup downloads directory
downloadsDir := s.settings.DownloadsDir()
if downloadsDir.NotExist() {
Expand All @@ -87,7 +93,7 @@ func (s *arduinoCoreServerImpl) Create(ctx context.Context, req *rpc.CreateReque
if err != nil {
return nil, err
}
inst, err := instances.Create(dataDir, packagesDir, userPackagesDir, downloadsDir, "", config)
inst, err := instances.Create(dataDir, packagesDir, userPackagesDir, downloadsDir, userAgent, config)
if err != nil {
return nil, err
}
Expand Down
Loading