Set installer tmp path to env var #2730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
per1234
added
type: enhancement
alessio-perugini
requested changes
Oct 14, 2024
alessio-perugini
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
This is an improvement in the
install.shscript to support more platforms. For example, Termux is an Android terminal emulator which doesn't follow conventional UNIX file system, which means/tmpfolder does not exist. Although,$TMPDIRis a variable that can be used to reference the/tmpequivalent in Termux.What is the current behavior?
The current behavior of the
install.shscript is that it crashes when running from Termux, as the installer tries to write the installation files in a folder that doesn't exist (/tmp).What is the new behavior?
A new variable
$TEMPDIRis defined based on some default variables that holds those paths, and if none of those are found, it defaults to previous/tmp.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Android environments have the potential to be a development environment, so it would be nice that tools like arduino-cli could support it.