Skip to content

[skip-changelog] Improve install.sh error message when the CLI binary is not found #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Mar 5, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

The error message that is displayed when the install.sh script does not find the arduino-cli binary has been made clearer.

What is the new behavior?

No changes.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 5, 2024
@MatteoPologruto MatteoPologruto requested a review from cmaglie March 5, 2024 10:57
@MatteoPologruto MatteoPologruto self-assigned this Mar 5, 2024
@MatteoPologruto MatteoPologruto merged commit ad9936f into arduino:master Mar 20, 2024
@MatteoPologruto MatteoPologruto deleted the improve-install-script-error-message branch March 20, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wording of installer script's warning about not finding arduino-cli in path is not clear
2 participants