gRPC Compile
will now fail if a platform core has been modified.
#2551
+408
−132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Before starting a compilation the platforms are checked for changes on the main files
boards.txt
,platform.txt
, andprogrammers.txt
. If a change is detected, the compile fails with anInstanceNeedsReinitializationError
.A gRPC client would need to perform a new
Init
call to update the in-memory structures, and retry the compile.What is the current behavior?
If a core platform file (
boards.txt
,platform.txt
, orprogrammers.txt
) is modified, the compile is performed with the old files already loaded in memory, leading to #2523.What is the new behavior?
The compile fails with an
InstanceNeedsReinitializationError
.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information