Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Retrieve programmer's information from the profile if the flag is not…
… used
  • Loading branch information
MatteoPologruto committed Jan 18, 2024
commit 23a115211b49015904c82ba7cf9c66567e742578
7 changes: 6 additions & 1 deletion commands/upload/upload.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,14 +146,19 @@ func Upload(ctx context.Context, req *rpc.UploadRequest, outStream io.Writer, er
fqbn = pme.GetProfile().FQBN
}

programmer := req.GetProgrammer()
if programmer == "" && pme.GetProfile() != nil {
programmer = pme.GetProfile().Programmer
}

updatedPort, err := runProgramAction(
pme,
sk,
req.GetImportFile(),
req.GetImportDir(),
fqbn,
req.GetPort(),
req.GetProgrammer(),
programmer,
req.GetVerbose(),
req.GetVerify(),
false, // burnBootloader
Expand Down
5 changes: 5 additions & 0 deletions internal/cli/arguments/programmer.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,8 @@ func (p *Programmer) String(inst *commands.Instance, fqbn string) string {
}
return details.GetDefaultProgrammerId()
}

// GetProgrammer returns the programmer specified by the user
func (p *Programmer) GetProgrammer() string {
return p.programmer
}
7 changes: 6 additions & 1 deletion internal/cli/compile/compile.go
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@ func runCompileCommand(cmd *cobra.Command, args []string) {
}
}

prog := profile.GetProgrammer()
if prog == "" || programmer.GetProgrammer() != "" {
prog = programmer.String(inst, fqbn)
}

uploadRequest := &rpc.UploadRequest{
Instance: inst,
Fqbn: fqbn,
Expand All @@ -276,7 +281,7 @@ func runCompileCommand(cmd *cobra.Command, args []string) {
Verbose: verbose,
Verify: verify,
ImportDir: buildPath,
Programmer: programmer.String(inst, fqbn),
Programmer: prog,
UserFields: fields,
}

Expand Down
7 changes: 6 additions & 1 deletion internal/cli/upload/upload.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,11 @@ func runUploadCommand(args []string, uploadFieldsArgs map[string]string) {
path = sketchPath.String()
}

prog := profile.GetProgrammer()
if prog == "" || programmer.GetProgrammer() != "" {
prog = programmer.String(inst, fqbn)
}

stdOut, stdErr, stdIOResult := feedback.OutputStreams()
req := &rpc.UploadRequest{
Instance: inst,
Expand All @@ -186,7 +191,7 @@ func runUploadCommand(args []string, uploadFieldsArgs map[string]string) {
Verify: verify,
ImportFile: importFile,
ImportDir: importDir,
Programmer: programmer.String(inst, fqbn),
Programmer: prog,
DryRun: dryRun,
UserFields: fields,
}
Expand Down