Skip to content

legacy: Arduino preprocess subroutine refactorization (part 3) #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 8 commits into from
May 31, 2023
Merged

legacy: Arduino preprocess subroutine refactorization (part 3) #2193

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f0190df
Converted CTagsRunner into a function
cmaglie Apr 5, 2023
a58c901
Removed useless tasks from ctags_runner test
cmaglie Apr 5, 2023
aa9e438
Simplified ctags_runner test
cmaglie Apr 5, 2023
5875f09
Removed some ctags related fields from builder context
cmaglie Apr 5, 2023
3408445
Simplified RunCTags / factored test subroutine
cmaglie Apr 5, 2023
818b0e7
Removed DebugPreprocessor from builder ctx
cmaglie Apr 5, 2023
91770d8
Added executils.RunAndCaptureOutput
cmaglie Apr 5, 2023
3eac673
Moved RunCTags out of legacy package
cmaglie Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed useless tasks from ctags_runner test
  • Loading branch information
@cmaglie
cmaglie committed May 30, 2023
commit a58c90143f9ff6d2087b28d0b11b920df1e77e7d
15 changes: 0 additions & 15 deletions legacy/builder/test/ctags_runner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ func TestCTagsRunner(t *testing.T) {
ctx.LineOffset, ctx.SketchSourceMerged, _err = bldr.PrepareSketchBuildPath(ctx.Sketch, ctx.SourceOverride, ctx.SketchBuildPath)
return _err
}),
&builder.ContainerFindIncludes{},
&builder.PrintUsedLibrariesIfVerbose{},
&builder.WarnAboutArchIncompatibleLibraries{},
types.BareCommand(func(ctx *types.Context) error {
ctagsOutput, _, _, _, _err = builder.RunCTags(ctx.Sketch, ctx.SketchSourceMerged, "ctags_target.cpp", ctx.BuildProperties, ctx.PreprocPath)
return _err
Expand Down Expand Up @@ -78,9 +75,6 @@ func TestCTagsRunnerSketchWithClass(t *testing.T) {
ctx.LineOffset, ctx.SketchSourceMerged, _err = bldr.PrepareSketchBuildPath(ctx.Sketch, ctx.SourceOverride, ctx.SketchBuildPath)
return _err
}),
&builder.ContainerFindIncludes{},
&builder.PrintUsedLibrariesIfVerbose{},
&builder.WarnAboutArchIncompatibleLibraries{},
types.BareCommand(func(ctx *types.Context) error {
ctagsOutput, _, _, _, _err = builder.RunCTags(ctx.Sketch, ctx.SketchSourceMerged, "ctags_target.cpp", ctx.BuildProperties, ctx.PreprocPath)
return _err
Expand Down Expand Up @@ -114,9 +108,6 @@ func TestCTagsRunnerSketchWithTypename(t *testing.T) {
ctx.LineOffset, ctx.SketchSourceMerged, _err = bldr.PrepareSketchBuildPath(ctx.Sketch, ctx.SourceOverride, ctx.SketchBuildPath)
return _err
}),
&builder.ContainerFindIncludes{},
&builder.PrintUsedLibrariesIfVerbose{},
&builder.WarnAboutArchIncompatibleLibraries{},
types.BareCommand(func(ctx *types.Context) error {
ctagsOutput, _, _, _, _err = builder.RunCTags(ctx.Sketch, ctx.SketchSourceMerged, "ctags_target.cpp", ctx.BuildProperties, ctx.PreprocPath)
return _err
Expand Down Expand Up @@ -149,9 +140,6 @@ func TestCTagsRunnerSketchWithNamespace(t *testing.T) {
ctx.LineOffset, ctx.SketchSourceMerged, _err = bldr.PrepareSketchBuildPath(ctx.Sketch, ctx.SourceOverride, ctx.SketchBuildPath)
return _err
}),
&builder.ContainerFindIncludes{},
&builder.PrintUsedLibrariesIfVerbose{},
&builder.WarnAboutArchIncompatibleLibraries{},
types.BareCommand(func(ctx *types.Context) error {
ctagsOutput, _, _, _, _err = builder.RunCTags(ctx.Sketch, ctx.SketchSourceMerged, "ctags_target.cpp", ctx.BuildProperties, ctx.PreprocPath)
return _err
Expand Down Expand Up @@ -183,9 +171,6 @@ func TestCTagsRunnerSketchWithTemplates(t *testing.T) {
ctx.LineOffset, ctx.SketchSourceMerged, _err = bldr.PrepareSketchBuildPath(ctx.Sketch, ctx.SourceOverride, ctx.SketchBuildPath)
return _err
}),
&builder.ContainerFindIncludes{},
&builder.PrintUsedLibrariesIfVerbose{},
&builder.WarnAboutArchIncompatibleLibraries{},
types.BareCommand(func(ctx *types.Context) error {
ctagsOutput, _, _, _, _err = builder.RunCTags(ctx.Sketch, ctx.SketchSourceMerged, "ctags_target.cpp", ctx.BuildProperties, ctx.PreprocPath)
return _err
Expand Down