Skip to content

Removed no more needed checks to go sub-programs #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2023
Merged

Removed no more needed checks to go sub-programs #2109

merged 1 commit into from
Mar 15, 2023

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 14, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Since the following:

  • arduino/discovery/discovery_client
  • client_example
  • commands/daemon/term_example
  • docsgen

are no more separate go modules there is no more need to run vet, fix, lint, fmt, and tidy on all of them.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie self-assigned this Mar 14, 2023
@cmaglie cmaglie added topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement labels Mar 14, 2023
umbynos
umbynos suggested changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove also:

https://github.com/cmaglie/arduino-cli/blob/9bc0161575b8e787c3f5293e461915eae8a2ff9b/.licensed.yml#L10-L13 (see https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/check-go-dependencies-task.md#project-paths)

@cmaglie cmaglie force-pushed the remove_no_more_needed_checks branch from 9bc0161 to 41de85d Compare March 15, 2023 14:10
@cmaglie cmaglie requested a review from umbynos March 15, 2023 14:28
@cmaglie cmaglie merged commit 183d5e9 into arduino:master Mar 15, 2023
@cmaglie cmaglie deleted the remove_no_more_needed_checks branch March 15, 2023 15:02
kittaakos pushed a commit to kittaakos/arduino-cli that referenced this pull request Mar 21, 2023
@cmaglie
Removed no more needed checks to go sub-programs (arduino#2109)
94e8073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 Awaiting requested review from per1234

@Bikappa Bikappa Awaiting requested review from Bikappa

@MatteoPologruto MatteoPologruto Awaiting requested review from MatteoPologruto

1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmaglie cmaglie

Labels

topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmaglie @umbynos