Skip to content

Extend code-coverage to integration test #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Extend code-coverage to integration test #2103

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85c14e5
Upgrade minimum go version to 1.20
cmaglie Mar 9, 2023
c2364be
Updated license cache
cmaglie Mar 9, 2023
6ec13e7
Implemented code coverage in integration tests
cmaglie Mar 9, 2023
3154ebb
Use gocovmerge to merge all coverage artifacts
cmaglie Mar 9, 2023
27ac5fd
Fixed build error on macOS dist
cmaglie Mar 10, 2023
eacd81c
Before killing the daemon, try a graceful shutdown
cmaglie Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Before killing the daemon, try a graceful shutdown 
Otherwise the process will not outut the coverage data.
  • Loading branch information
@cmaglie
cmaglie committed Mar 14, 2023
commit eacd81c5b35b381a24f6949de1c6720b5089c718
11 changes: 9 additions & 2 deletions internal/integrationtest/arduino-cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ type ArduinoCLI struct {
path *paths.Path
t *require.Assertions
proc *executils.Process
stdIn io.WriteCloser
cliEnvVars map[string]string
cliConfigPath *paths.Path
stagingDir *paths.Path
Expand Down Expand Up @@ -122,7 +123,12 @@ func NewArduinoCliWithinEnvironment(env *Environment, config *ArduinoCLIConfig)
func (cli *ArduinoCLI) CleanUp() {
if cli.proc != nil {
cli.daemonConn.Close()
cli.proc.Kill()
cli.stdIn.Close()
proc := cli.proc
go func() {
time.Sleep(time.Second)
proc.Kill()
}()
cli.proc.Wait()
}
}
Expand Down Expand Up @@ -251,10 +257,11 @@ func (cli *ArduinoCLI) StartDaemon(verbose bool) string {
cli.t.NoError(err)
stderr, err := cliProc.StderrPipe()
cli.t.NoError(err)
_, err = cliProc.StdinPipe()
stdIn, err := cliProc.StdinPipe()
cli.t.NoError(err)

cli.t.NoError(cliProc.Start())
cli.stdIn = stdIn
cli.proc = cliProc
cli.daemonAddr = "127.0.0.1:50051"

Expand Down