Skip to content

[breaking] Add post install script support for tools #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2023
Merged

[breaking] Add post install script support for tools #2075

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9d139a
Add post install script support for tools
MatteoPologruto Feb 14, 2023
748c439
Add TestCoreInstallRunsToolPostInstallScript to core_test.go
MatteoPologruto Feb 14, 2023
339242e
Document changes in UPGRADING.md
MatteoPologruto Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add TestCoreInstallRunsToolPostInstallScript to core_test.go
  • Loading branch information
@MatteoPologruto
MatteoPologruto committed Feb 20, 2023
commit 748c4390565de93a8b9da58032c0877701928aed
15 changes: 15 additions & 0 deletions internal/integrationtest/core/core_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,3 +992,18 @@ func TestCoreInstallCreatesInstalledJson(t *testing.T) {
sortedExpected := requirejson.Parse(t, expectedInstalledJson).Query("walk(if type == \"array\" then sort else . end)").String()
require.JSONEq(t, sortedExpected, sortedInstalled)
}

func TestCoreInstallRunsToolPostInstallScript(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp()

url := "http://drazzy.com/package_drazzy.com_index.json"

_, _, err := cli.Run("core", "update-index", "--additional-urls", url)
require.NoError(t, err)

// Checks that the post_install script is correctly skipped on the CI
stdout, _, err := cli.Run("core", "install", "ATTinyCore:avr", "--verbose", "--additional-urls", url)
require.NoError(t, err)
require.Contains(t, string(stdout), "Skipping tool configuration.")
}