Skip to content

[skip-changelog] Migrate twelve tests from test_lib.py to lib_test.go #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 2, 2022
Merged

[skip-changelog] Migrate twelve tests from test_lib.py to lib_test.go #1989

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
182831d
Migrate TestList from test_lib.py to lib_test.go
MatteoPologruto Nov 3, 2022
54d6258
Migrate TestListExitCode from test_lib.py to lib_test.go
MatteoPologruto Nov 3, 2022
dbf8a33
Migrate TestListWithFqbn from test_lib.py to lib_test.go
MatteoPologruto Nov 3, 2022
12153ec
Migrate TestListProvidesIncludesFallback from test_lib.py to lib_test.go
MatteoPologruto Nov 3, 2022
ed0e364
Migrate TestLibDownload from test_lib.py to lib_test.go
MatteoPologruto Nov 3, 2022
77d8846
Migrate TestInstall from test_lib.py to lib_test.go
MatteoPologruto Nov 3, 2022
f46f0c2
Migrate TestInstallLibraryWithDependencies from test_lib.py to lib_te…
MatteoPologruto Nov 3, 2022
1562879
Migrate TestInstallNoDeps from test_lib.py to lib_test.go
MatteoPologruto Nov 3, 2022
c5e168e
Migrate TestInstallWithGitUrl from test_lib.py to lib_test.go
MatteoPologruto Nov 3, 2022
c5a062a
Migrate TestInstallWithGitUrlFragmentAsBranch from test_lib.py to lib…
MatteoPologruto Nov 3, 2022
e8f525b
Migrate TestUpdateIndex from test_lib.py to lib_test.go
MatteoPologruto Nov 3, 2022
e535c1e
Migrate TestUninstall from test_lib.py to lib_test.go
MatteoPologruto Nov 3, 2022
779ccb5
Reduce quoting using verbatim strings and improve jq queries
MatteoPologruto Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Migrate TestUpdateIndex from test_lib.py to lib_test.go
  • Loading branch information
@MatteoPologruto
MatteoPologruto committed Dec 2, 2022
commit e8f525be6b45f59e7fc49d1f5eb42690f27eba7e
9 changes: 9 additions & 0 deletions internal/integrationtest/lib/lib_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,3 +655,12 @@ func TestInstallWithGitUrlFragmentAsBranch(t *testing.T) {
// Verifies library remains installed
require.DirExists(t, libInstallDir.String())
}

func TestUpdateIndex(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp()

stdout, _, err := cli.Run("lib", "update-index")
require.NoError(t, err)
require.Contains(t, string(stdout), "Downloading index: library_index.tar.bz2 downloaded")
}
7 changes: 0 additions & 7 deletions test/test_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,6 @@ def test_install_with_zip_path(run_command, data_dir, downloads_dir):
assert lib_install_dir / "README.adoc" in files


def test_update_index(run_command):
result = run_command(["lib", "update-index"])
assert result.ok
lines = [l.strip() for l in result.stdout.splitlines()]
assert "Downloading index: library_index.tar.bz2 downloaded" in lines


def test_uninstall(run_command):
libs = ["Arduino_BQ24195", "WiFiNINA"]
assert run_command(["lib", "install"] + libs)
Expand Down