Skip to content

Fix regression: do not crash on board list if a discovery is not properly installed #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2022
Merged

Fix regression: do not crash on board list if a discovery is not properly installed #1814

merged 2 commits into from
Jul 26, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jul 25, 2022 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    Better handling of discovery startup in case the discovery is not properly installed.
  • What is the new behavior?
    The CLI does not crash anymore

@cmaglie cmaglie self-assigned this Jul 25, 2022
@cmaglie cmaglie linked an issue Jul 25, 2022 that may be closed by this pull request
Recover from interrupted discovery/monitor installation #1669
Closed
@cmaglie cmaglie added type: imperfection Perceived defect in any part of project topic: CLI Related to the command line interface criticality: high Of high impact labels Jul 25, 2022
@cmaglie cmaglie requested review from umbynos and per1234 July 25, 2022 14:38
@cmaglie cmaglie merged commit 5332ffd into arduino:master Jul 26, 2022
@cmaglie cmaglie deleted the fix_regression branch July 26, 2022 09:20
@per1234 per1234 mentioned this pull request Aug 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 Awaiting requested review from per1234

1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@cmaglie cmaglie

Labels
criticality: high Of high impact topic: CLI Related to the command line interface type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recover from interrupted discovery/monitor installation
2 participants
@cmaglie @umbynos