Skip to content

Now compile --only-compilation-database will run all pre-* hooks #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 17, 2021
Merged

Now compile --only-compilation-database will run all pre-* hooks #1549

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c8b0482
Clean up some useless constants
cmaglie Nov 16, 2021
c33e2a2
made legacy/builder.go independent from legacy/constants
cmaglie Nov 16, 2021
602008a
Now 'compile --only-compilation-database' will run all pre-* hooks
cmaglie Nov 16, 2021
bc4f7aa
Updated docs
cmaglie Nov 16, 2021
b24e93c
Update cli/compile/compile.go
cmaglie Nov 16, 2021
668eaf3
Update docs/platform-specification.md
cmaglie Nov 16, 2021
79fdbd9
Update test/test_compile_part_4.py
cmaglie Nov 16, 2021
6c3b8be
Update test/test_compile_part_4.py
cmaglie Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update cli/compile/compile.go 
Co-authored-by: per1234 <accounts@perglass.com>
  • Loading branch information
@cmaglie @per1234
cmaglie and per1234 authored Nov 16, 2021
commit b24e93c097f386224d4a67a040a8eddeeac2b64c
2 changes: 1 addition & 1 deletion cli/compile/compile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func NewCommand() *cobra.Command {
command.RegisterFlagCompletionFunc("programmer", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
return arguments.GetInstalledProgrammers(), cobra.ShellCompDirectiveDefault
})
command.Flags().BoolVar(&compilationDatabaseOnly, "only-compilation-database", false, tr("Just produce the compilation database, without actually compiling. All build commands are skipped except all the pre-* hooks."))
command.Flags().BoolVar(&compilationDatabaseOnly, "only-compilation-database", false, tr("Just produce the compilation database, without actually compiling. All build commands are skipped except pre* hooks."))
command.Flags().BoolVar(&clean, "clean", false, tr("Optional, cleanup the build folder and do not use any cached build."))
// We must use the following syntax for this flag since it's also bound to settings.
// This must be done because the value is set when the binding is accessed from viper. Accessing from cobra would only
Expand Down