Skip to content

Update index.go - fixes compatibility with package_seeeduino_boards_index.json #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

bmitov
Copy link

@bmitov bmitov commented Jun 24, 2021

Relaxed Unmarshaling of numeric size value

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
  • What is the current behavior?
  • What is the new behavior?
  • Other information:

See how to contribute

Relaxed Unmarshaling of numeric size value
@CLAassistant
Copy link

CLAassistant commented Jun 24, 2021

CLA assistant check
All committers have signed the CLA.

@per1234
Copy link
Contributor

per1234 commented Aug 4, 2021

Another occurrence of the class of package index error that motivated this PR: VSChina/azureiotdevkit_tools#61

@cmaglie
Copy link
Member

cmaglie commented Oct 11, 2022

I cannot reproduce it anymore with the current master:

$ arduino-cli config dump
board_manager:
  additional_urls:
  - http://raw.githubusercontent.com/damellis/attiny/ide-1.6.x-boards-manager/package_damellis_attiny_index.json
  - https://www.pjrc.com/teensy/td_156/package_teensy_index.json
  - https://m5stack.oss-cn-shenzhen.aliyuncs.com/resource/arduino/package_m5stack_index.json
  - https://raw.githubusercontent.com/VSChina/azureiotdevkit_tools/master/package_azureboard_index.json
[......]
$ arduino-cli core update-index
Sto scaricando l'indice: package_index.tar.bz2 downloaded                                                                                                                                                  
Sto scaricando l'indice: package_damellis_attiny_index.json downloaded                                                                                                                                     
Sto scaricando l'indice: package_teensy_index.json downloaded                                                                                                                                              
Sto scaricando l'indice: package_m5stack_index.json downloaded                                                                                                                                             
Sto scaricando l'indice: package_azureboard_index.json downloaded                                                                                                                                          


$ arduino-cli core search azure
ID             Versione Nome                                      
AZ3166:stm32f4 2.0.0    MXChip - Microsoft Azure IoT Developer Kit

$ cat ~/.arduino15/package_azureboard_index.json |grep 3788484
          "size": "3788484 ",
$

may we close this one as auto-solved?

@cmaglie
Copy link
Member

cmaglie commented Oct 12, 2022

Since I'm not able to reproduce it anymore, I'm going ahead and closing this PR.
Feel free to reopen if I'm wrong or if there is more information to add.

@cmaglie cmaglie closed this Oct 12, 2022
@per1234
Copy link
Contributor

per1234 commented Oct 12, 2022

The behavior was changed by #1274. Platform releases with an invalid format such as whitespace in the packages[*].platforms[*].size field are now simply ignored. The user will not see them in the platform listings, nor be able to install them.

@per1234 per1234 added type: enhancement Proposed improvement conclusion: declined Will not be worked on topic: code Related to content of the project itself labels Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core update-index results in "panic: minor version must not be prefixed with zero"
5 participants