[skip changelog] Update notarization job, now usable with p12 cert format #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
requested changes
Nov 11, 2020
There was a problem hiding this comment.
Thanks Umberto!
I tried it out in my fork with my own Apple Developer ID certificate and it works just fine.
This will also need to be done to the "nightly" workflow:
https://github.com/arduino/arduino-cli/blob/master/.github/workflows/nightly.yaml
Co-authored-by: per1234 <accounts@perglass.com>
rsora
suggested changes
Nov 11, 2020
with homebrew tap is not possible to install an exact version of an app
per1234
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Looks good!
per@Pers-iMac Downloads % spctl -a -vvv -t install "dist/arduino-cli_43.0.0_macOS_64bit/arduino-cli"
dist/arduino-cli_43.0.0_macOS_64bit/arduino-cli: accepted
source=Notarized Developer ID
origin=Developer ID Application: Per Tillisch (9M5NQMNWBJ)
per@Pers-iMac Downloads % spctl -a -vvv -t install "dist (1)/arduino-cli_0.13.0_macOS_64bit/arduino-cli"
dist (1)/arduino-cli_0.13.0_macOS_64bit/arduino-cli: accepted
source=Notarized Developer ID
origin=Developer ID Application: ARDUINO SA (7KT7ZWMCJT)
rsora
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
update the CI
The CI now uses a
.p12certificates and uses an action to handle keychain unlocking. Other improvements have been added.Now gon is installed through homebrew.
The
Notarize binary, re-package it and update checksumstep has been split in two different steps: one simple step to notarize and sign and the other one to change permission, calculate the checksum and repackage the binaryno
See how to contribute
It's necessary to add
INSTALLER_CERT_MAC_P12andINSTALLER_CERT_MAC_PASSWORDas secrets