-
-
Notifications
You must be signed in to change notification settings - Fork 398
UploadResult#updated_upload_port
might be missing from the UploadResponse
#2287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The structure of the
🐛 On
✅ On
|
Outputs with
|
Ref: arduino/arduino-cli#2287 Closes #2203 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
The fix provided via #2288 might be a partial one. After some experimenting, I could not find a use case when the updated port was absent from the upload result, but the port has changed, and the updated port is incorrect in the response. Steps to reproduce with the CLI:
After the upload, the port is
|
I could not reproduce the defect with I do not know what has changed. I am closing it and will reopen it if I can reproduce the bug. |
Describe the problem
During the upload to a board, the port might change. After #2253, the CLI can detect it and provide this information to clients. As requested at #2253 (review), the upload port must always be set whether it has changed or not. Sometimes it's missing.
To reproduce
I could reproduce when the port was missing using the command line way of the CLI:
🐛 It fails with
Arduino Nano 33 BLE
:✅ It works with
Arduino Uno
:Expected behavior
updated_upload_port
is always part of the response.Arduino CLI version
0.34.0
Operating system
macOS
Operating system version
13.5
Additional context
I ran into a runtime error in IDE2. I am on a branch and working on new things. Hence, the breaking change can be IDE2. During debugging, I've seen partial
Port
objects with only theprotocol
andaddress
properties via gRPC. The two things could be unrelated. However, theupload response was: {}
log suggests the missingUploadResult
message from the response.Issue checklist
The text was updated successfully, but these errors were encountered: