Migrate TestCoreUpdateWithLocalUrl from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -17,6 +17,7 @@ package core_test
 
 import (
 	"fmt"
+	"runtime"
 	"strings"
 	"testing"
 
@@ -370,3 +371,18 @@ func TestCoreBrokenInstall(t *testing.T) {
 	_, _, err = cli.Run("core", "install", "brokenchecksum:x86", "--additional-urls="+url)
 	require.Error(t, err)
 }
+
+func TestCoreUpdateWithLocalUrl(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	wd, _ := paths.Getwd()
+	testIndex := wd.Parent().Join("testdata", "test_index.json").String()
+	if runtime.GOOS == "windows" {
+		testIndex = "/" + strings.ReplaceAll(testIndex, "\\", "/")
+	}
+
+	stdout, _, err := cli.Run("core", "update-index", "--additional-urls=file://"+testIndex)
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), "Downloading index: test_index.json downloaded")
+}

test/test_core.py

@@ -68,16 +68,6 @@ def ordered(obj):
     assert ordered(installed_json) == ordered(expected_installed_json)
 
 
-def test_core_update_with_local_url(run_command):
-    test_index = str(Path(__file__).parent / "testdata" / "test_index.json")
-    if platform.system() == "Windows":
-        test_index = f"/{test_index}".replace("\\", "/")
-
-    res = run_command(["core", "update-index", f'--additional-urls="file://{test_index}"'])
-    assert res.ok
-    assert "Downloading index: test_index.json downloaded" in res.stdout
-
-
 def test_core_search_manually_installed_cores_not_printed(run_command, data_dir):
     assert run_command(["core", "update-index"])