Migrate TestCoreBrokenInstall from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -359,3 +359,14 @@ func TestCoreZipslip(t *testing.T) {
 	require.Error(t, err)
 	require.NoFileExists(t, paths.TempDir().Join("evil.txt").String())
 }
+
+func TestCoreBrokenInstall(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	url := "https://raw.githubusercontent.com/arduino/arduino-cli/master/test/testdata/test_index.json"
+	_, _, err := cli.Run("core", "update-index", "--additional-urls="+url)
+	require.NoError(t, err)
+	_, _, err = cli.Run("core", "install", "brokenchecksum:x86", "--additional-urls="+url)
+	require.Error(t, err)
+}

test/test_core.py

@@ -47,12 +47,6 @@ def test_core_install_esp32(run_command, data_dir):
     assert (build_dir / f"{sketch_name}.ino.partitions.bin").exists()
 
 
-def test_core_broken_install(run_command):
-    url = "https://raw.githubusercontent.com/arduino/arduino-cli/master/test/testdata/test_index.json"
-    assert run_command(["core", "update-index", f"--additional-urls={url}"])
-    assert not run_command(["core", "install", "brokenchecksum:x86", "--additional-urls={url}"])
-
-
 def test_core_install_creates_installed_json(run_command, data_dir):
     assert run_command(["core", "update-index"])
     assert run_command(["core", "install", "arduino:avr@1.6.23"])