Migrate TestCoreListAllManuallyInstalledCore from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -18,6 +18,7 @@ package core_test
 import (
 	"fmt"
 	"runtime"
+	"strconv"
 	"strings"
 	"testing"
 
@@ -417,3 +418,38 @@ func TestCoreSearchManuallyInstalledCoresNotPrinted(t *testing.T) {
 	requirejson.NotContains(t, stdout, `[{"id": "arduino-beta-development:avr"}]`)
 	require.Equal(t, oldJson, stdout)
 }
+
+func TestCoreListAllManuallyInstalledCore(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	// Verifies only cores in board manager are shown
+	stdout, _, err := cli.Run("core", "list", "--all", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Query(t, stdout, "length > 0", "true")
+	len, _ := strconv.Atoi(requirejson.Parse(t, stdout).Query("length").String())
+
+	// Manually installs a core in sketchbooks hardware folder
+	gitUrl := "https://github.com/arduino/ArduinoCore-avr.git"
+	repoDir := cli.SketchbookDir().Join("hardware", "arduino-beta-development", "avr")
+	_, err = git.PlainClone(repoDir.String(), false, &git.CloneOptions{
+		URL:           gitUrl,
+		ReferenceName: plumbing.NewTagReferenceName("1.8.3"),
+	})
+	require.NoError(t, err)
+
+	// Verifies manually installed core is shown
+	stdout, _, err = cli.Run("core", "list", "--all", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Len(t, stdout, len+1)
+	requirejson.Contains(t, stdout, `[
+		{
+			"id": "arduino-beta-development:avr",
+			"latest": "1.8.3",
+			"name": "Arduino AVR Boards"
+			}
+		]`)
+}

test/test_core.py

@@ -68,33 +68,6 @@ def ordered(obj):
     assert ordered(installed_json) == ordered(expected_installed_json)
 
 
-def test_core_list_all_manually_installed_core(run_command, data_dir):
-    assert run_command(["core", "update-index"])
-
-    # Verifies only cores in board manager are shown
-    res = run_command(["core", "list", "--all", "--format", "json"])
-    assert res.ok
-    cores = json.loads(res.stdout)
-    num_cores = len(cores)
-    assert num_cores > 0
-
-    # Manually installs a core in sketchbooks hardware folder
-    git_url = "https://github.com/arduino/ArduinoCore-avr.git"
-    repo_dir = Path(data_dir, "hardware", "arduino-beta-development", "avr")
-    assert Repo.clone_from(git_url, repo_dir, multi_options=["-b 1.8.3"])
-
-    # Verifies manually installed core is shown
-    res = run_command(["core", "list", "--all", "--format", "json"])
-    assert res.ok
-    cores = json.loads(res.stdout)
-    assert num_cores + 1 == len(cores)
-    mapped = {core["id"]: core for core in cores}
-    expected_core_id = "arduino-beta-development:avr"
-    assert expected_core_id in mapped
-    assert "Arduino AVR Boards" == mapped[expected_core_id]["name"]
-    assert "1.8.3" == mapped[expected_core_id]["latest"]
-
-
 def test_core_list_updatable_all_flags(run_command, data_dir):
     assert run_command(["core", "update-index"])