Migrate TestCoreSearchManuallyInstalledCoresNotPrinted from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -25,6 +25,8 @@ import (
 	"github.com/arduino/go-paths-helper"
 	"github.com/stretchr/testify/require"
 	"go.bug.st/testifyjson/requirejson"
+	"gopkg.in/src-d/go-git.v4"
+	"gopkg.in/src-d/go-git.v4/plumbing"
 )
 
 func TestCorrectHandlingOfPlatformVersionProperty(t *testing.T) {
@@ -386,3 +388,32 @@ func TestCoreUpdateWithLocalUrl(t *testing.T) {
 	require.NoError(t, err)
 	require.Contains(t, string(stdout), "Downloading index: test_index.json downloaded")
 }
+
+func TestCoreSearchManuallyInstalledCoresNotPrinted(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	// Verifies only cores in board manager are shown
+	stdout, _, err := cli.Run("core", "search", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Query(t, stdout, "length > 0", "true")
+	oldJson := stdout
+
+	// Manually installs a core in sketchbooks hardware folder
+	gitUrl := "https://github.com/arduino/ArduinoCore-avr.git"
+	repoDir := cli.SketchbookDir().Join("hardware", "arduino-beta-development", "avr")
+	_, err = git.PlainClone(repoDir.String(), false, &git.CloneOptions{
+		URL:           gitUrl,
+		ReferenceName: plumbing.NewTagReferenceName("1.8.3"),
+	})
+	require.NoError(t, err)
+
+	// Verifies manually installed core is not shown
+	stdout, _, err = cli.Run("core", "search", "--format", "json")
+	require.NoError(t, err)
+	requirejson.NotContains(t, stdout, `[{"id": "arduino-beta-development:avr"}]`)
+	require.Equal(t, oldJson, stdout)
+}

test/test_core.py

@@ -68,31 +68,6 @@ def ordered(obj):
     assert ordered(installed_json) == ordered(expected_installed_json)
 
 
-def test_core_search_manually_installed_cores_not_printed(run_command, data_dir):
-    assert run_command(["core", "update-index"])
-
-    # Verifies only cores in board manager are shown
-    res = run_command(["core", "search", "--format", "json"])
-    assert res.ok
-    cores = json.loads(res.stdout)
-    num_cores = len(cores)
-    assert num_cores > 0
-
-    # Manually installs a core in sketchbooks hardware folder
-    git_url = "https://github.com/arduino/ArduinoCore-avr.git"
-    repo_dir = Path(data_dir, "hardware", "arduino-beta-development", "avr")
-    assert Repo.clone_from(git_url, repo_dir, multi_options=["-b 1.8.3"])
-
-    # Verifies manually installed core is not shown
-    res = run_command(["core", "search", "--format", "json"])
-    assert res.ok
-    cores = json.loads(res.stdout)
-    assert num_cores == len(cores)
-    mapped = {core["id"]: core for core in cores}
-    core_id = "arduino-beta-development:avr"
-    assert core_id not in mapped
-
-
 def test_core_list_all_manually_installed_core(run_command, data_dir):
     assert run_command(["core", "update-index"])