Skip to content

Improve the arduino-app-cli version command by adding the "server version" #31 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 11, 2025
Merged

Improve the arduino-app-cli version command by adding the "server version" #31 #49

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fd939c5
Add the server version to arduino-app-cli version.
martacarbone Nov 6, 2025
466245c
Add copyright header.
martacarbone Nov 6, 2025
bf435c6
Address review comments.
martacarbone Nov 7, 2025
a5d95ea
Fix lint.
martacarbone Nov 10, 2025
776bcca
Address review
martacarbone Nov 10, 2025
7aba0e1
Define the port only as custom input.
martacarbone Nov 11, 2025
a9b0ca2
Update cmd/arduino-app-cli/version/version.go
martacarbone Nov 11, 2025
ef78764
Update cmd/arduino-app-cli/version/version.go
martacarbone Nov 11, 2025
0f6e212
Update cmd/arduino-app-cli/version/version.go
martacarbone Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint.
  • Loading branch information
@martacarbone
martacarbone committed Nov 10, 2025
commit a5d95eaf634b7d2356b858c36de1f4ca19d0388c
2 changes: 1 addition & 1 deletion cmd/arduino-app-cli/version/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func versionHandler(httpClient http.Client, clientVersion string, hostAndPort st

func validateHost(hostPort string) (string, error) {
if !strings.Contains(hostPort, ":") {
hostPort = hostPort + ":"
hostPort += ":"
}

h, p, err := net.SplitHostPort(hostPort)
Expand Down