bug: fix required_devices handling #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjtokenring
changed the title
rjtokenring
commented
Dec 4, 2025
|
|
||
| // The following code is needed only if the brick requires a container. | ||
| // In case it doesn't we just skip to the next one. | ||
| if !idxBrick.RequireContainer { |
Contributor
Author
There was a problem hiding this comment.
required devices was loading after checking if bricks requires a container.
So, required devices are not loaded in case of bricks without a container
lucarin91
approved these changes
Dec 4, 2025
Xayton
approved these changes
Dec 4, 2025
Contributor
Xayton
left a comment
Xayton
left a comment
There was a problem hiding this comment.
Tested with the new examples (not merged yet).
Works as expected: you get a no speaker device found message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
required_devicessection must be checked also in case there are no linked containers.Change description
Move detection logic before code loop exiting
Reviewer checklist
main.