-
-
Notifications
You must be signed in to change notification settings - Fork 64
No need for the F() macro on the the megaavr architecture #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Totally agree on this; would you like to open a PR so I can give the right attribution? |
Sure, but that PR has to go into the Arduino API repo (String.h IIRC). I thought this repo should be kept architecture-neutral? Because this is very much an architecture relate thing. |
Correct; probably the right approach is to |
Did this a0f6beb (which reverted the fix) break this again or do you have another solution for the F() Flash Macro which is present in many codes? |
Hi @habazut , |
I'll leave this here:
SpenceKonde/megaTinyCore#81
In short terms, it has no RAM usage benefits, but it wastes flash memory. Should probably be defined as
#define F(string_literal) (string_literal)
instead.The text was updated successfully, but these errors were encountered: