-
-
Notifications
You must be signed in to change notification settings - Fork 212
Nudge user to use the M7 for bootloader and WiFi updates #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
07e4ab0
to
d50d3dc
Compare
@per1234 What's your suggestion on making the CI happy with this? |
Memory usage change @ d50d3dc
Click for full report table
Click for full report CSV
|
Memory usage change @ 859a463
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the slow response. The CI configuration change looks good.
@per1234 I removed the the system sketches from the M4 compile workflow. Are we good with those changes? |
In my opinion it doesn't make much sense to allow the users to upload the bootloader / wifi FW update sketch to the M4 as they would need to force-boot the M4 on the M7 just for that. If someone accidentally chooses the M4 core they may wonder why nothing happens.
This PR forces the users to use the M7 for those updates.