Skip to content

[AE-74] Revamp Battery API for Nicla Sense ME #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
May 12, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
965fb69
nicla-system: Rework battery API.
sebromero Apr 26, 2023
d8fc798
nicla-sense-pmic: Use function to toggle Hi-Z mode.
sebromero Apr 26, 2023
20ee494
nicla-system: Add battery monitor web app.
sebromero Apr 27, 2023
864d9a3
nicla-system: Add battery check sketch for Nicla Sense.
sebromero Apr 27, 2023
bd0ee3e
nicla-system: Add function for toggling battery NTC.
sebromero Apr 28, 2023
a47ec88
nicla-system: Refactor names.
sebromero Apr 28, 2023
254eecb
nicla-system: Remove duplicate functionality.
sebromero May 2, 2023
66bc141
nicla-system: Add API for operating system.
sebromero May 2, 2023
3b0af63
nicla-system: Rename function.
sebromero May 2, 2023
edaf109
nicla-system: Use getFaultsRegister to query faults register.
sebromero May 2, 2023
03cbd92
nicla-system: Add documentation.
sebromero May 2, 2023
1c55bb5
nicla-system: Remove battery status function.
sebromero May 2, 2023
c29e363
nicla-system: Replace defines with enum for battery level.
sebromero May 2, 2023
9f7b9a9
nicla-system: Add getter for fast charge register.
sebromero May 2, 2023
f14d519
nicla-system: Replace battery temperature with enum.
sebromero May 2, 2023
6e8f454
nicla-system: Add API to set regulated battery voltage.
sebromero May 2, 2023
d2c93a0
nicla-system: Move function to read LDO register to pmic driver.
sebromero May 2, 2023
56b67be
nicla-system: Catch error case.
sebromero May 3, 2023
d69d3ad
nicla-system: Rename function name.
sebromero May 3, 2023
444a74d
nicla-system: Improve efficiency of voltage calculation.
sebromero May 3, 2023
0708980
nicla-system: Fix incorrect INT disable.
sebromero May 3, 2023
e6ff5c5
nicla-system: Add documentation to charging function.
sebromero May 3, 2023
6d8c08a
nicla-system: Rename charging function.
sebromero May 3, 2023
9f1b6cc
nicla-system: Avoid High-Z mode when powered from VIN.
sebromero May 3, 2023
ad89fb1
nicla-system: Add function to check if board runs on battery.
sebromero May 3, 2023
6ab5b66
nicla-system: Add documentation to LDO functions.
sebromero May 4, 2023
6286728
nicla-system: Add function to disable charging.
sebromero May 4, 2023
abbc54f
nicla-system: Disable charging while taking a battery reading.
sebromero May 4, 2023
2871417
nicla-system: Display charging and power status.
sebromero May 4, 2023
de371ef
nicla-system: Make BLE updates more robust.
sebromero May 4, 2023
4dee246
nicla-system: Add documentation to the web app.
sebromero May 4, 2023
48fb48e
nicla-system: Change order of setup instructions.
sebromero May 4, 2023
cea8fa2
nicla-system: Add function for backwards compatibility.
sebromero May 4, 2023
b16d5ea
nicla-system: Give PMIC more time to wake up.
sebromero May 5, 2023
b3d7f82
nicla-system: Add error messages to sketch.
sebromero May 5, 2023
f7845c2
nicla-system: Fix incorrect battery voltage reading.
sebromero May 9, 2023
d47a6db
nicla-system: Add documentation about charging rate.
sebromero May 9, 2023
a0b13de
nicla-system: Remove NTC toggling from charge function.
sebromero May 9, 2023
f5e6718
nicla-system: Add more documentation.
sebromero May 10, 2023
d2271c1
nicla-system: Simplify the watchdog reset machanism.
sebromero May 10, 2023
14117b6
nicla-system: Remove unused code.
sebromero May 10, 2023
d399ee3
nicla-system: Increase safety charge time from 3 to 9 hours.
sebromero May 10, 2023
9bce6e8
nicla-system: Add more documentation.
sebromero May 11, 2023
c316d06
nicla-system: Add sketch that shows how to charge the battery.
sebromero May 11, 2023
21a7c56
nicla-system: Add new measurement of charge current to docs.
sebromero May 11, 2023
e51a021
nicla-system: Add option to configure safety timer.
sebromero May 11, 2023
5fff648
nicla-system: Make the safety timer configuration explicit.
sebromero May 11, 2023
1ca6fc3
nicla-system: Apply suggestions from Ali's code review.
sebromero May 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nicla-system: Add API to set regulated battery voltage.
  • Loading branch information
sebromero committed May 4, 2023
commit 6e8f4541039770bfc336e83f3f798a8988d234a8
54 changes: 37 additions & 17 deletions libraries/Nicla_System/src/Nicla_System.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,38 @@ float nicla::getRegulatedBatteryVoltage(){

}

void nicla::setRegulatedBatteryVoltage(float voltage){
if (voltage < 3.6f){
voltage = 3.6f;
} else if (voltage > 4.2f) {
voltage = 4.2f;
}

// The formula is: VBATREG = 3.6 V + Sum(VBREG[Bit 7:1])

/*
+---------+--------------------+
| Bit | Regulation Voltage |
+---------+--------------------+
| 7 (MSB) | 640 mV |
| 6 | 320 mV |
| 5 | 160 mV |
| 4 | 80 mV |
| 3 | 40 mV |
| 2 | 20 mV |
| 1 | 10 mV |
| 0 (LSB) | – |
+---------+--------------------+
*/

// Shift one bit to the left because the LSB is not used.
uint16_t additionalMilliVolts = (voltage - 3.6f) * 100;
uint8_t value = additionalMilliVolts << 1;
// e.g. 4.2V - 3.6V = 0.6V * 100 = 60. 60 << 1 = 120 = 01111000

_pmic.writeByte(BQ25120A_ADDRESS, BQ25120A_BATTERY_CTRL, value);
}

float nicla::getCurrentBatteryVoltage(){
return getRegulatedBatteryVoltage() / 100 * getBatteryPercentage();
}
Expand Down Expand Up @@ -284,12 +316,9 @@ BatteryChargeLevel nicla::getBatteryChargeLevel() {
}
}

uint8_t nicla::getBatteryTemperature() {
if(!_ntcEnabled) return BATTERY_TEMPERATURE_NORMAL;
BatteryTemperature nicla::getBatteryTemperature() {
if(!_ntcEnabled) return BatteryTemperature::Normal;

// Extract bits 5 and 6 (TS_FAULT0 and TS_FAULT1)
uint8_t temperatureSenseFault = _pmic.readByte(BQ25120A_ADDRESS, BQ25120A_TS_CONTROL) >> 5 & 0b11;

/*
+------+-------------------------------------------------------------+
| Bits | Description |
Expand All @@ -300,18 +329,9 @@ uint8_t nicla::getBatteryTemperature() {
| 11 | TWARM < TS temp < THOT (Charging voltage reduced by 140 mV) |
+------+-------------------------------------------------------------+
*/

if(temperatureSenseFault == 0){
return BATTERY_TEMPERATURE_NORMAL;
} else if (temperatureSenseFault == 1) {
return BATTERY_TEMPERATURE_EXTREME;
} else if (temperatureSenseFault == 2) {
return BATTERY_TEMPERTURE_COOL;
} else if (temperatureSenseFault == 3) {
return BATTERY_TEMPERTURE_WARM;
}

return BATTERY_TEMPERATURE_NORMAL;
// Extract bits 5 and 6 (TS_FAULT0 and TS_FAULT1)
uint8_t temperatureSenseFault = _pmic.readByte(BQ25120A_ADDRESS, BQ25120A_TS_CONTROL) >> 5 & 0b11;
return static_cast<BatteryTemperature>(temperatureSenseFault);
}


Expand Down
7 changes: 7 additions & 0 deletions libraries/Nicla_System/src/Nicla_System.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ class nicla {
*/
static float getRegulatedBatteryVoltage();

/**
* @brief Set the Regulated Battery Voltage.
*
* @param voltage The voltage in the range of 3.6V to 4.65V.
*/
static void setRegulatedBatteryVoltage(float voltage);

/**
* @brief Get the Current Battery Voltage in Volts. This value is calculated by multiplying
* the regulated voltage by the battery percentage.
Expand Down