Implementing test code for "CanStandardId", "CanExtendedId", "isStandardId", "isExtendedId".

Author: aentinger

Diff for: test/CMakeLists.txt

@@ -25,6 +25,10 @@ set(TEST_TARGET ${CMAKE_PROJECT_NAME})
 ##########################################################################
 
 set(TEST_SRCS
+  src/CanMsg/test_CanExtendedId.cpp
+  src/CanMsg/test_CanStandardId.cpp
+  src/CanMsg/test_isExtendedId.cpp
+  src/CanMsg/test_isStandardId.cpp
   src/Common/test_makeWord.cpp
   src/Common/test_map.cpp
   src/Common/test_max.cpp
@@ -95,6 +99,7 @@ set(TEST_SRCS
 )
 
 set(TEST_DUT_SRCS
+  ../api/CanMsg.cpp
   ../api/Common.cpp
   ../api/IPAddress.cpp
   ../api/String.cpp

Diff for: test/src/CanMsg/test_CanExtendedId.cpp

@@ -0,0 +1,41 @@
+/*
+ * Copyright (c) 2020 Arduino.  All rights reserved.
+ */
+
+/**************************************************************************************
+ * INCLUDE
+ **************************************************************************************/
+
+#include <catch.hpp>
+
+#include <CanMsg.h>
+
+/**************************************************************************************
+ * NAMESPACE
+ **************************************************************************************/
+
+using namespace arduino;
+
+/**************************************************************************************
+ * TEST CODE
+ **************************************************************************************/
+
+TEST_CASE ("Verify correct conversion to 29-Bit CAN ID for lowest valid 29-Bit CAN ID", "[CanMsg-CanExtendedId-01]")
+{
+  REQUIRE(CanExtendedId(0) == (CanMsg::CAN_EFF_FLAG | 0U));
+}
+
+TEST_CASE ("Verify correct conversion to 29-Bit CAN ID for highest valid 29-Bit CAN ID", "[CanMsg-CanExtendedId-02]")
+{
+  REQUIRE(CanExtendedId(0x1FFFFFFFU) == (CanMsg::CAN_EFF_FLAG | 0x1FFFFFFFU));
+}
+
+TEST_CASE ("Verify capping of CAN IDs exceeding 29-Bit CAN ID range", "[CanMsg-CanExtendedId-03]")
+{
+  REQUIRE(CanExtendedId(0x2FFFFFFFU) == (CanMsg::CAN_EFF_FLAG | 0x0FFFFFFFU));
+  REQUIRE(CanExtendedId(0x3FFFFFFFU) == (CanMsg::CAN_EFF_FLAG | 0x1FFFFFFFU));
+  REQUIRE(CanExtendedId(0x4FFFFFFFU) == (CanMsg::CAN_EFF_FLAG | 0x0FFFFFFFU));
+  REQUIRE(CanExtendedId(0x5FFFFFFFU) == (CanMsg::CAN_EFF_FLAG | 0x1FFFFFFFU));
+  /* ... */
+  REQUIRE(CanExtendedId(0xFFFFFFFFU) == (CanMsg::CAN_EFF_FLAG | 0x1FFFFFFFU));
+}

Diff for: test/src/CanMsg/test_CanStandardId.cpp

@@ -0,0 +1,40 @@
+/*
+ * Copyright (c) 2020 Arduino.  All rights reserved.
+ */
+
+/**************************************************************************************
+ * INCLUDE
+ **************************************************************************************/
+
+#include <catch.hpp>
+
+#include <CanMsg.h>
+
+/**************************************************************************************
+ * NAMESPACE
+ **************************************************************************************/
+
+using namespace arduino;
+
+/**************************************************************************************
+ * TEST CODE
+ **************************************************************************************/
+
+TEST_CASE ("Verify correct conversion to 11-Bit CAN ID for lowest valid 11-Bit CAN ID", "[CanMsg-CanStandardId-01]")
+{
+  REQUIRE(CanStandardId(0) == 0U);
+}
+
+TEST_CASE ("Verify correct conversion to 11-Bit CAN ID for highest valid 11-Bit CAN ID", "[CanMsg-CanStandardId-02]")
+{
+  REQUIRE(CanStandardId(0x7FF) == 0x7FF);
+}
+
+TEST_CASE ("Verify capping of CAN IDs exceeding 11-Bit CAN ID range", "[CanMsg-CanStandardId-03]")
+{
+  REQUIRE(CanStandardId(0x800U)      == 0x000U);
+  REQUIRE(CanStandardId(0x801U)      == 0x001U);
+  REQUIRE(CanStandardId(0x8FFU)      == 0x0FFU);
+  REQUIRE(CanStandardId(0x1FFFFFFFU) == 0x7FFU);
+  REQUIRE(CanStandardId(0xFFFFFFFFU) == 0x7FFU);
+}

Diff for: test/src/CanMsg/test_isExtendedId.cpp

@@ -0,0 +1,33 @@
+/*
+ * Copyright (c) 2020 Arduino.  All rights reserved.
+ */
+
+/**************************************************************************************
+ * INCLUDE
+ **************************************************************************************/
+
+#include <catch.hpp>
+
+#include <CanMsg.h>
+
+/**************************************************************************************
+ * NAMESPACE
+ **************************************************************************************/
+
+using namespace arduino;
+
+/**************************************************************************************
+ * TEST CODE
+ **************************************************************************************/
+
+TEST_CASE ("\"isExtendedId\" should return true for extended CAN ID", "[CanMsg-isExtendedId-01]")
+{
+  CanMsg const msg_ext_id(CanExtendedId(0x020), 0, nullptr);
+  REQUIRE(msg_ext_id.isExtendedId() == true);
+}
+
+TEST_CASE ("\"isExtendedId\" should return false for standard CAN ID", "[CanMsg-isExtendedId-02]")
+{
+  CanMsg const msg_std_id(CanStandardId(0x020), 0, nullptr);
+  REQUIRE(msg_std_id.isExtendedId() == false);
+}

Diff for: test/src/CanMsg/test_isStandardId.cpp

@@ -0,0 +1,33 @@
+/*
+ * Copyright (c) 2020 Arduino.  All rights reserved.
+ */
+
+/**************************************************************************************
+ * INCLUDE
+ **************************************************************************************/
+
+#include <catch.hpp>
+
+#include <CanMsg.h>
+
+/**************************************************************************************
+ * NAMESPACE
+ **************************************************************************************/
+
+using namespace arduino;
+
+/**************************************************************************************
+ * TEST CODE
+ **************************************************************************************/
+
+TEST_CASE ("\"isStandardId\" should return true for standard CAN ID", "[CanMsg-isStandardId-01]")
+{
+  CanMsg const msg_std_id(CanStandardId(0x020), 0, nullptr);
+  REQUIRE(msg_std_id.isStandardId() == true);
+}
+
+TEST_CASE ("\"isStandardId\" should return false for extended CAN ID", "[CanMsg-isStandardId-02]")
+{
+  CanMsg const msg_ext_id(CanExtendedId(0x020), 0, nullptr);
+  REQUIRE(msg_ext_id.isStandardId() == false);
+}