Skip to content

Add Buttons in Library and Boards managers #9164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2019

Conversation

joew46167
Copy link

Using the new "use accessibility features" settings option, when the option is selected then instead of more info and online help links in the description there are now buttons for these features that do the same thing as the links.

As a side note, when the option is not selected, the links will now include translated strings for the links. This made coding the buttons easier, and imo makes the links better.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes

Tested in Windows with NVDA.

@joew46167
Copy link
Author

Some of the commits came from rebasing after my previous pull request was merged in.

@joew46167
Copy link
Author

Oh, I forgot to separate out another commit.

When these managers open the focus is set to the filter edit box, but the name isn't read. So I added a description for that edit box.

@joew46167
Copy link
Author

Failed checks are all:

Use explicit scoping instead of the default package private level

for each of the lines where I declared a new button. I debated between adding the word private to my buttons, or leaving them as they are without the word private, or adding the word private to all of the buttons to maintain code consistency. I chose to just leave it as it is.

Please advise if I should change

@facchinm
Copy link
Member

Please advise if I should change

Not necessary to change it, thanks

}
else {
// if not accessible IDE, keep link the same EXCEPT that now the link text is translated!
retString += " " + format("<a href=\"{0}\">{1}</a>", url, label);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change this into retString += format("<a href=\"{0}\">{1}</a><br/>", url, label); to target the other comment

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I did in code change for other comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the extra space at the beginning is still needed though... Better leave it there and eventually tackle it in a refactor to uniform the setButtonOrLink methods

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe that space is - or ever was - needed. That space is not use in the library manager version.

I've been looking for a utils class to move that method to, but I haven't found a home for it.

Do you want it changed? sounds like no.

@facchinm facchinm merged commit aaef922 into arduino:master Aug 22, 2019
@cmaglie cmaglie added this to the Release 1.8.11 milestone Jan 22, 2020
@per1234 per1234 added accessibility Enabling the use of the software by everyone Component: Board/Lib Manager Boards Manager or Library Manager Component: IDE user interface The Arduino IDE's user interface labels Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Enabling the use of the software by everyone Component: Board/Lib Manager Boards Manager or Library Manager Component: IDE user interface The Arduino IDE's user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants