-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Add Buttons in Library and Boards managers #9164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some of the commits came from rebasing after my previous pull request was merged in. |
Oh, I forgot to separate out another commit. When these managers open the focus is set to the filter edit box, but the name isn't read. So I added a description for that edit box. |
Failed checks are all: Use explicit scoping instead of the default package private level for each of the lines where I declared a new button. I debated between adding the word private to my buttons, or leaving them as they are without the word private, or adding the word private to all of the buttons to maintain code consistency. I chose to just leave it as it is. Please advise if I should change |
Not necessary to change it, thanks |
app/src/cc/arduino/contributions/packages/ui/ContributedPlatformTableCellJPanel.java
Show resolved
Hide resolved
} | ||
else { | ||
// if not accessible IDE, keep link the same EXCEPT that now the link text is translated! | ||
retString += " " + format("<a href=\"{0}\">{1}</a>", url, label); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change this into retString += format("<a href=\"{0}\">{1}</a><br/>", url, label);
to target the other comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I did in code change for other comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the extra space at the beginning is still needed though... Better leave it there and eventually tackle it in a refactor to uniform the setButtonOrLink
methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe that space is - or ever was - needed. That space is not use in the library manager version.
I've been looking for a utils class to move that method to, but I haven't found a home for it.
Do you want it changed? sounds like no.
…ll users where they are
…ttons instead of links
9c0f6c8
to
1b515b1
Compare
Using the new "use accessibility features" settings option, when the option is selected then instead of more info and online help links in the description there are now buttons for these features that do the same thing as the links.
As a side note, when the option is not selected, the links will now include translated strings for the links. This made coding the buttons easier, and imo makes the links better.
All Submissions:
New Feature Submissions:
Changes to Core Features:
Tested in Windows with NVDA.