Skip to content

Add Shift+click on serial monitor toolbar button to open serial plotter #11028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Add Shift+click on serial monitor toolbar button to open serial plotter #11028

merged 1 commit into from
Dec 4, 2020

Conversation

n-elia
Copy link
Contributor

@n-elia n-elia commented Dec 3, 2020

Feature

The change involves the Serial Monitor button on the toolbar.

  • Before: click to open Serial Monitor, shift+click to open Serial Monitor
  • After: click to open Serial Monitor, shift+click to open Serial Plotter

Changed files

  • app/src/processing/app/EditorToolbar.java

Details

I added the if(isShiftDown) check on the Serial Monitor button, too. In case of Shift being pressed down, editor.handlePlotter() is invoked. I changed the title of the button accordingly to this.
As you can see in the picture, works fine on Windows.

@per1234 per1234 added Component: IDE user interface The Arduino IDE's user interface Component: IDE Serial monitor Tools > Serial Monitor feature request A request to make an enhancement (not a bug fix) labels Dec 3, 2020
Copy link
Collaborator

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, sounds like a useful change.

I had a quick look at the code, looks good to me. I haven't tested the code, though.

@n-elia
Copy link
Contributor Author

n-elia commented Dec 4, 2020

Thank you!
It shouldn't create problems because I used the very same fashion of other buttons.
I built arduino-1.8.14-windows and it works fine in every common situation (I'm using it on daily basis to work on multiple projects), it's very handy!
If I can help further, just let me know 👍

@facchinm facchinm merged commit 350e825 into arduino:master Dec 4, 2020
@facchinm
Copy link
Member

facchinm commented Dec 4, 2020

Thank you for the contribution, very handy indeed 😉

@per1234 per1234 added SerialPlotter Tools > Serial Plotter and removed Component: IDE Serial monitor Tools > Serial Monitor labels Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE user interface The Arduino IDE's user interface feature request A request to make an enhancement (not a bug fix) SerialPlotter Tools > Serial Plotter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants