Clean up examples to remove warnings [imported]

[cmaglie]

This is Issue 693 moved from a Google Code project.
Added by 2011-10-24T01:49:13.000Z by maniac...@ymail.com.
Please review that bug for more context and additional comments, but update this bug.

Original labels: Type-Defect, Priority-Medium, Component-Examples

Original description

Some examples have warnings which indicate where a few clean-ups could be made. This patch fixes all those.

(If it doesn't apply cleanly let me know, I'll regenerate one from a clean repo)

[per1234]

Done:

• BlinkWithoutDelay.ino: 83ef181
• Arrays.ino: a6022df
• StringIndexOf.ino: 47bcf07
• StringToIntRGB.ino: This file is no longer part of the bundled examples.

WontFix:

• StringLength.ino: I think this change is not desirable because it introduces a type (size_t) that the target audience of the bundled examples will not be familiar with.

 String txtMsg = "";                         // a string for incoming text
-int lastStringLength = txtMsg.length();     // previous length of the String
+size_t lastStringLength = txtMsg.length();     // previous length of the String

and the return type of length() is unsigned int (https://github.com/arduino/Arduino/blob/master/hardware/arduino/avr/cores/arduino/WString.h#L81). However, the warning should be fixed and I have submitted a PR for this: #6449

To Do

• StringAdditionOperator.ino: Will be fixed by Remove unused variable from StringAdditionOperator example #6448