Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcc reorder warning #72

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Fix gcc reorder warning #72

merged 1 commit into from
Jul 14, 2022

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Jul 8, 2022

This will satisfy gcc complaining about reordering the initializer list.

NOTE:
The last ESP32 core is enforcing -Wall -Werror=all compiler flags using https://github.com/espressif/arduino-esp32/blob/2.0.4/platform.txt#L105-L110 so a wrong initialization order will cause a build error.

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

Memory usage change @ 0fe67a4

Board flash % RAM for global variables %
arduino:megaavr:uno2018 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/WiFiAdvancedCallback
flash
% examples/WiFiAdvancedCallback
RAM for global variables
% examples/WiFiEcho
flash
% examples/WiFiEcho
RAM for global variables
% examples/WiFiEchoCallback
flash
% examples/WiFiEchoCallback
RAM for global variables
% examples/WiFiSimpleReceive
flash
% examples/WiFiSimpleReceive
RAM for global variables
% examples/WiFiSimpleReceiveCallback
flash
% examples/WiFiSimpleReceiveCallback
RAM for global variables
% examples/WiFiSimpleSender
flash
% examples/WiFiSimpleSender
RAM for global variables
%
arduino:megaavr:uno2018 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/WiFiAdvancedCallback<br>flash,%,examples/WiFiAdvancedCallback<br>RAM for global variables,%,examples/WiFiEcho<br>flash,%,examples/WiFiEcho<br>RAM for global variables,%,examples/WiFiEchoCallback<br>flash,%,examples/WiFiEchoCallback<br>RAM for global variables,%,examples/WiFiSimpleReceive<br>flash,%,examples/WiFiSimpleReceive<br>RAM for global variables,%,examples/WiFiSimpleReceiveCallback<br>flash,%,examples/WiFiSimpleReceiveCallback<br>RAM for global variables,%,examples/WiFiSimpleSender<br>flash,%,examples/WiFiSimpleSender<br>RAM for global variables,%
arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@pennam pennam requested a review from aentinger July 8, 2022 08:51
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jul 9, 2022
@aentinger
Copy link
Contributor

The last ESP32 core is enforcing -Wall -Werror=all compiler flags

Do they now? Very laudable 👏

@pennam
Copy link
Contributor Author

pennam commented Jul 11, 2022

I think yes, -Werror=all is enabled only for higher warning levels: more and all

https://github.com/espressif/arduino-esp32/blob/2.0.4/platform.txt#L105-L110

@pennam pennam merged commit 6647685 into master Jul 14, 2022
@pennam pennam deleted the reorder-warning branch July 21, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants