Skip to content

Conversation

@aentinger
Copy link
Contributor

In the current implementation the number the board would continously attempt to obtain the last values from the cloud. If, however, those values never arrive - then the board would never move on and become operational. It's therefore better to count the number of failed attempts and reset the connection to allow a clean re-connection from the ground up.

In the current implementation the number the board would continously attempt to obtain the last values from the cloud. If, however, those values never arrive - then the board would never move on and become operational. It's therefore better to count the number of failed attempts and reset the connection to allow a clean re-connection from the ground up.
@aentinger aentinger added the type: enhancement Proposed improvement label May 3, 2021
@aentinger aentinger self-assigned this May 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2021

Codecov Report

Merging #249 (6e3408c) into master (10d35e4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files          24       24           
  Lines         867      867           
=======================================
  Hits          825      825           
  Misses         42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10d35e4...6e3408c. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 3, 2021

Memory usage change @ 6e3408c

Board flash % RAM for global variables %
arduino:mbed:envie_m4 🔺 0 - +64 0.0 - +0.01 🔺 +8 - +8 0.0 - 0.0
arduino:mbed:envie_m7 🔺 0 - +64 0.0 - +0.01 🔺 +8 - +8 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +32 0.0 - 0.0 🔺 0 - +8 0.0 - 0.0
arduino:samd:mkr1000 🔺 +24 - +32 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 +24 - +24 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 +24 - +32 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +16 0.0 - +0.01 🔺 0 - +8 0.0 - +0.02
arduino:samd:nano_33_iot 🔺 0 - +16 0.0 - +0.01 🔺 0 - +8 0.0 - +0.02
esp32:esp32:esp32 🔺 +28 - +28 0.0 - 0.0 🔺 0 - +8 0.0 - 0.0
esp8266:esp8266:huzzah 🔺 +32 - +48 0.0 - 0.0 🔺 0 - +16 0.0 - +0.02
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
% examples/ArduinoIoTCloud-Advanced
RAM for global variables
% examples/ArduinoIoTCloud-Basic
flash
% examples/ArduinoIoTCloud-Basic
RAM for global variables
% examples/utility/ArduinoIoTCloud_Travis_CI
flash
% examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
% examples/utility/Provisioning
flash
% examples/utility/Provisioning
RAM for global variables
% examples/utility/SelfProvisioning
flash
% examples/utility/SelfProvisioning
RAM for global variables
%
arduino:mbed:envie_m4 64 0.01 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0
arduino:mbed:envie_m7 0 0.0 8 0.0 0 0.0 8 0.0 64 0.01 8 0.0 0 0.0 8 0.0
arduino:mbed_nano:nanorp2040connect 32 0.0 8 0.0 32 0.0 8 0.0 32 0.0 8 0.0 32 0.0 8 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 24 0.01 0 0.0 32 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0
arduino:samd:mkrgsm1400 24 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0
arduino:samd:mkrnb1500 24 0.01 0 0.0 32 0.01 0 0.0 32 0.01 0 0.0 24 0.01 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 16 0.01 8 0.02 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 8 0.02 0 0.0 0 0.0
arduino:samd:nano_33_iot 16 0.01 8 0.02 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 8 0.02 0 0.0 0 0.0
esp32:esp32:esp32 28 0.0 8 0.0 28 0.0 0 0.0 28 0.0 0 0.0
esp8266:esp8266:huzzah 48 0.0 0 0.0 32 0.0 16 0.02 48 0.0 16 0.02
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,64,0.01,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0
arduino:mbed:envie_m7,0,0.0,8,0.0,0,0.0,8,0.0,64,0.01,8,0.0,0,0.0,8,0.0
arduino:mbed_nano:nanorp2040connect,32,0.0,8,0.0,32,0.0,8,0.0,32,0.0,8,0.0,32,0.0,8,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,24,0.01,0,0.0,32,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,,,,
arduino:samd:mkrgsm1400,24,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,,,,
arduino:samd:mkrnb1500,24,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,24,0.01,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,16,0.01,8,0.02,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,8,0.02,0,0.0,0,0.0
arduino:samd:nano_33_iot,16,0.01,8,0.02,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,8,0.02,0,0.0,0,0.0
esp32:esp32:esp32,28,0.0,8,0.0,28,0.0,0,0.0,28,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,48,0.0,0,0.0,32,0.0,16,0.02,48,0.0,16,0.02,,,,,,,,

@aentinger aentinger merged commit 71ee279 into master May 3, 2021
@aentinger aentinger deleted the request-last-values-retry-counter branch May 3, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants