[BTS-2203] Add ResourceMonitor to ShortestPathExecutorInfos #22014
Conversation
…lder and _targetBuilder to be supervised
knakatasf
changed the title
| _pathLength(0), | ||
| _sourceBuilder{}, | ||
| _targetBuilder{} { | ||
| _sourceBuilder(std::make_shared<velocypack::SupervisedBuffer>( |
There was a problem hiding this comment.
Can't the supervised buffer be built on the stack as _sourceBuilder is a class member, is gonna linger there, and no one's gonna steal the buffer from it?
There was a problem hiding this comment.
It can, however the original does a make_shared buffer by itself so this is same ballpark.
This also comes with the downside that we need to put supervised buffer as include in the header.
There was a problem hiding this comment.
I brought back the include in the header because the other file is .tpp and has no includes
| _targetBuilder{} { | ||
| _sourceBuilder(std::make_shared<velocypack::SupervisedBuffer>( | ||
| infos.resourceMonitor())), | ||
| _targetBuilder(std::make_shared<velocypack::SupervisedBuffer>( |
| _pathLength(0), | ||
| _sourceBuilder{}, | ||
| _targetBuilder{} { | ||
| _sourceBuilder(std::make_shared<velocypack::SupervisedBuffer>( |
There was a problem hiding this comment.
It can, however the original does a make_shared buffer by itself so this is same ballpark.
This also comes with the downside that we need to put supervised buffer as include in the header.
Co-authored-by: Michael Hackstein <michael@arangodb.com>
…rtest-path-executor-memory-monitoring
…thub.com:arangodb/arangodb into feature/shortest-path-executor-memory-monitoring
…rtest-path-executor-memory-monitoring
…rtest-path-executor-memory-monitoring
…rtest-path-executor-memory-monitoring
…rtest-path-executor-memory-monitoring
3 participants
Scope & Purpose
ShortestPathExecutor holds 2 builder objects:
_sourceBuilderand_targetBuilder. Refactored them to be supervised by adding SupervisedBuffer.[Future work]
_pathBuilderis a BuilderLeaser. This should be counted manually or by implementing supervised BuilderLeaser.💩 Bugfix
🍕 New feature
🔥 Performance improvement
🔨 Refactoring/simplification
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)