examples/std/ta: Add Cargo.lock to pin crate versions #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It reminds me of: Adding |
Thanks for pointing this out. I've added this to my TODO list. |
|
@ivila Could you help to give a review or ack tag for merge? thanks! |
Sure😀 |
Std TAs depend on a custom port of Rust toolchain with OP-TEE targets. However, third-party crates are frequently updated and may require a newer Rust version, which can break builds for std-based TAs. Add Cargo.lock file to lock crate versions as workaround. Signed-off-by: Yuan Zhuang <yuanz@apache.org> Acked-by: Zehui Chen <ivila@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Std TAs depend on a custom port of Rust toolchain with OP-TEE targets. Currently, we manually pin the Rust version and port the Rust std accordingly.
However, third-party crates are frequently updated and may require a newer Rust version, which can break builds for std-based TAs (#188). Additionally, building reliably is also important for release stability.
To address this, this PR includes
Cargo.lockfile to lock crate versions for std TAs.BTW upstreaming the
opteetarget to Rust might resolve this issue. However, the maintenance effort are still unclear for us and needs further evaluation. For now, to prepare for the upcoming release, I'd like to propose this PR as workaround.