Skip to content

[ISSUE #797] Fix msg lost if consumer crash when send msg back failed. #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2022
Merged

[ISSUE #797] Fix msg lost if consumer crash when send msg back failed. #860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix msg lost if consumer crash when send msg back failed.
  • Loading branch information
@ShannonDing
ShannonDing committed Jul 21, 2022
commit b212ff29e562c3d5ef1c10f728535eb4f1fe7570
8 changes: 6 additions & 2 deletions consumer/push_consumer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,8 +1037,10 @@ func (pc *pushConsumer) consumeMessageCurrently(pq *processQueue, mq *primitive.

if !pq.IsDroppd() {
msgBackFailed := make([]*primitive.MessageExt, 0)
msgBackSucceed := make([]*primitive.MessageExt, 0)
if result == ConsumeSuccess {
pc.stat.increaseConsumeOKTPS(pc.consumerGroup, mq.Topic, len(subMsgs))
msgBackSucceed = subMsgs
} else {
pc.stat.increaseConsumeFailedTPS(pc.consumerGroup, mq.Topic, len(subMsgs))
if pc.model == BroadCasting {
Expand All @@ -1050,15 +1052,17 @@ func (pc *pushConsumer) consumeMessageCurrently(pq *processQueue, mq *primitive.
} else {
for i := 0; i < len(subMsgs); i++ {
msg := subMsgs[i]
if !pc.sendMessageBack(mq.BrokerName, msg, concurrentCtx.DelayLevelWhenNextConsume) {
if pc.sendMessageBack(mq.BrokerName, msg, concurrentCtx.DelayLevelWhenNextConsume) {
msgBackSucceed = append(msgBackSucceed, msg)
} else {
msg.ReconsumeTimes += 1
msgBackFailed = append(msgBackFailed, msg)
}
}
}
}

offset := pq.removeMessage(subMsgs...)
offset := pq.removeMessage(msgBackSucceed...)

if offset >= 0 && !pq.IsDroppd() {
pc.storage.update(mq, int64(offset), true)
Expand Down