Skip to content

fix(material/button): inherit button shape in focus indicator #31065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 9, 2025

Updates the button's focus indicator to inherit the shape of its button which looks better than the current approach.

Before:
image

After:
image

@crisbeto crisbeto requested a review from a team as a code owner May 9, 2025 14:30
@crisbeto crisbeto removed the request for review from a team May 9, 2025 14:30
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label May 9, 2025
@crisbeto crisbeto requested review from adolgachev and mmalerba May 9, 2025 14:30
Updates the button's focus indicator to inherit the shape of its button which looks better than the current approach.
@crisbeto crisbeto force-pushed the inherit-indicator-shape branch from ff5aa09 to 088df46 Compare May 11, 2025 07:13
@crisbeto crisbeto requested a review from andrewseguin May 11, 2025 19:09
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 12, 2025
@crisbeto crisbeto merged commit d27f793 into angular:main May 12, 2025
24 of 25 checks passed
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 19.2.x, 20.0.x

crisbeto added a commit that referenced this pull request May 12, 2025
Updates the button's focus indicator to inherit the shape of its button which looks better than the current approach.

(cherry picked from commit d27f793)
crisbeto added a commit that referenced this pull request May 12, 2025
Updates the button's focus indicator to inherit the shape of its button which looks better than the current approach.

(cherry picked from commit d27f793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: material/button target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants