Skip to content

refactor: removed the Unexpected empty object pattern #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: removed the Unexpected empty object pattern #3386

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8b907b
refactor: removed the Unexpected empty object pattern
alkavats1 Jun 23, 2023
f585bbf
Merge branch 'master' into emptyObject
davideast Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor: removed the Unexpected empty object pattern 
removed the empty object declaration from the collections
  • Loading branch information
@alkavats1
alkavats1 committed Jun 23, 2023
commit c8b907b34e082c5a341dfca116224c5d772a573c
2 changes: 1 addition & 1 deletion src/compat/firestore/collection-group/collection-group.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class AngularFirestoreCollectionGroup<T = DocumentData> {
*/
valueChanges(): Observable<T[]>;
// tslint:disable-next-line:unified-signatures
valueChanges({}): Observable<T[]>;
valueChanges(): Observable<T[]>;
valueChanges<K extends string>(options: {idField: K}): Observable<(T & { [T in K]: string })[]>;
valueChanges<K extends string>(options: {idField?: K} = {}): Observable<T[]> {
const fromCollectionRefScheduled$ = fromCollectionRef<T>(this.query, this.afs.schedulers.outsideAngular);
Expand Down
2 changes: 1 addition & 1 deletion src/compat/firestore/collection/collection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export class AngularFirestoreCollection<T = DocumentData> {
*/
valueChanges(): Observable<T[]>;
// tslint:disable-next-line:unified-signatures
valueChanges({}): Observable<T[]>;
valueChanges(): Observable<T[]>;
valueChanges<K extends string>(options: {idField: K}): Observable<(T & { [T in K]: string })[]>;
valueChanges<K extends string>(options: {idField?: K} = {}): Observable<T[]> {
return fromCollectionRef<T>(this.query, this.afs.schedulers.outsideAngular)
Expand Down