Skip to content

Fix functions emulator origin url #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

Fix functions emulator origin url #2471

merged 1 commit into from
Jun 2, 2020

Conversation

nikmartin
Copy link
Contributor

The default port in the firebase emulator for functions is 5001, not 5005

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Documentation fix for emulated function

Code sample

@nikmartin
Fix functions emulator origin url
813432d 
The default port in the firebase emulator for functions is 5001, not 5005
@jamesdaniels jamesdaniels merged commit 24734ff into angular:master Jun 2, 2020
@nikmartin nikmartin deleted the patch-1 branch June 2, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikmartin @jamesdaniels @googlebot