Skip to content

Firebase Hosting Integration only #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nikovic opened this issue Aug 13, 2019 · 5 comments
Closed

Firebase Hosting Integration only #2147

Nikovic opened this issue Aug 13, 2019 · 5 comments

Comments

@Nikovic
Copy link

Nikovic commented Aug 13, 2019

Under "Firebase Hosting Integration" (see https://github.com/angular/angularfire2/blob/master/docs/functions/functions.md#firebase-hosting-integration) you mention the possibility of avoiding a round-trip and other CORS-config.

This only applies to sites (firebase-)hosted via us-central1 though (firebase/firebase-tools#842), which I think would be nice to mention in the .md

@jamesdaniels
Copy link
Member

Agreed, this would be good to mention. Would you be able to take a stab at a PR? Otherwise I'll get to it at some point here.

@stephangrobler
Copy link
Contributor

I can update this for you. Will submit a PR shortly.

stephangrobler added a commit to stephangrobler/angularfire2 that referenced this issue Oct 9, 2019
@wiedzmin26
Copy link

@stephangrobler Please, do it. @Nikovic haven't done it yet and he will not do it.

@wiedzmin26
Copy link

@stephangrobler Thank you very much.

@stephangrobler
Copy link
Contributor

@wiedzmin26 Your welcome 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants