-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Firebase Hosting Integration only #2147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Agreed, this would be good to mention. Would you be able to take a stab at a PR? Otherwise I'll get to it at some point here. |
I can update this for you. Will submit a PR shortly. |
stephangrobler
added a commit
to stephangrobler/angularfire2
that referenced
this issue
Oct 9, 2019
@stephangrobler Please, do it. @Nikovic haven't done it yet and he will not do it. |
@stephangrobler Thank you very much. |
@wiedzmin26 Your welcome 😄 |
jamesdaniels
pushed a commit
that referenced
this issue
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Under "Firebase Hosting Integration" (see https://github.com/angular/angularfire2/blob/master/docs/functions/functions.md#firebase-hosting-integration) you mention the possibility of avoiding a round-trip and other CORS-config.
This only applies to sites (firebase-)hosted via us-central1 though (firebase/firebase-tools#842), which I think would be nice to mention in the .md
The text was updated successfully, but these errors were encountered: