Skip to content

Conversation

superole
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Documentation for the i18n-plural-pipe links to an old location of the ICU User Guide. It is still active, but the page clearly states that:

The ICU User Guide has moved to https://unicode-org.github.io/icu/userguide/.
Please update your bookmarks.
This obsolete site will be deleted.

Issue Number: N/A

What is the new behavior?

Documentation for the i18n-plural-pipe links to the current location of the ICU User Guide.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented Sep 22, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ngbot ngbot bot added this to the Backlog milestone Sep 22, 2022
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@superole thanks for improving Angular docs 👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Sep 22, 2022
@ngbot
Copy link

ngbot bot commented Sep 22, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google3" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir
Copy link
Contributor

Merge-assistance: docs-only change, does not require g3 presubmit. The PR is ready for merge.

@AndrewKushnir AndrewKushnir removed the request for review from alxhub September 22, 2022 17:25
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 26ad19e.

AndrewKushnir pushed a commit that referenced this pull request Sep 29, 2022
pterratpro pushed a commit to pterratpro/angular-fr that referenced this pull request Oct 4, 2022
pterratpro pushed a commit to pterratpro/angular-fr that referenced this pull request Oct 4, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants