Compiler generates ngfactory for file with no angular metadata #22193

filipesilva · 2018-02-13T10:16:56Z

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

Under some circumstances, the AOT compiler can generate a .ngfactory.ts file for a file with no Angular metadata:

must be using Angular CLI
must be using AOT compilation
must be using "module": "commonjs" in tsconfig (the CLI sets it automatically for ng serve, for performance reasons)
must have a namespace import (like import * as numeral from 'numeral';) in a file without angular decorators

When all these conditions are met, rebuilds will fail with the following stack trace:

ERROR in : TypeError: Cannot read property 'text' of undefined
    at getErrorSpanForNode (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:7880:40)
    at createDiagnosticForNodeInSourceFile (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:7804:20)
    at Object.createDiagnosticForNode (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:7800:16)
    at error (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:24149:22)
    at resolveExternalModule (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:25263:17)
    at resolveExternalModuleNameWorker (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:25253:20)
    at Object.getExternalModuleFileFromDeclaration (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:45763:32)
    at tryGetModuleNameFromDeclaration (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:50792:50)
    at Object.getExternalModuleNameLiteral (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:50756:20)
    at createRequireCall (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:63361:33)
    at visitExportDeclaration (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:63423:45)
    at sourceElementVisitor (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:63151:28)
    at Object.visitNodes (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:51105:48)
    at transformCommonJSModule (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:62890:40)
    at transformSourceFile (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:62863:27)
    at D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:2601:86
    at reduceLeft (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:2274:30)
    at D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:2601:42
    at transformRoot (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:65720:82)
    at Object.map (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:1725:29)
    at Object.transformNodes (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:65708:30)
    at Object.emitFiles (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:68442:28)
    at emitWorker (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:72519:33)
    at D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:72481:66
    at runWithCancellationToken (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:72573:24)
    at Object.emit (D:\sandbox\repro-bug-angular-cli\node_modules\typescript\lib\typescript.js:72481:20)
    at defaultEmitCallback (D:\sandbox\repro-bug-angular-cli\node_modules\@angular\compiler-cli\src\transformers\program.js:33:20)
    at D:\sandbox\repro-bug-angular-cli\node_modules\@angular\compiler-cli\src\transformers\program.js:231:109
    at Array.map (<anonymous>)
    at AngularCompilerProgram.emit (D:\sandbox\repro-bug-angular-cli\node_modules\@angular\compiler-cli\src\transformers\program.js:231:63)
    at AngularCompilerPlugin._emit (D:\sandbox\repro-bug-angular-cli\node_modules\@ngtools\webpack\src\angular_compiler_plugin.js:749:49)
    at Promise.resolve.then.then.then (D:\sandbox\repro-bug-angular-cli\node_modules\@ngtools\webpack\src\angular_compiler_plugin.js:582:54)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

Expected behavior

Compilation succeed.

Minimal reproduction of the problem with instructions

This issue was originally reported and reproduced in angular/angular-cli#9036:

git clone https://github.com/victornoel/repro-bug-angular-cli
cd repro-bug-angular-cli
npm i
npm start -- --aot
# edit a file, e.g. add `console.log(1);` to  `main.ts`

Environment


Angular version: 5.2.2

 
For Tooling issues:
- Node version: 8.9.1
- Platform:  Windows 10
- Angular CLI: 1.6.6

Others:

/cc @chuckjaz

The text was updated successfully, but these errors were encountered:

filipesilva · 2018-02-13T10:20:05Z

@chuckjaz looked at this problem yesterday and had this to say:

I believe this line is wrong https://github.com/angular/angular/blob/master/packages/compiler-cli/src/transformers/compiler_host.ts#L456 and is the genesis of the problem. We try to produce re-exports symbols for metadata that refer to files outside this compilation. The line cause the second file to treat the reference to "localData" in the locale.format.ts file as a reference to an external library.

The problem is only with commonjs in that it avoiding it avoids TypeScript trying to report an invalid import. The problem is still there it is just hiding. It will probably show up elsewhere until we fix the way new programs are created and how isSourceFile is reported in incremental builds.

He also suggested a workaround: type the problematic namespace import as any:

export function getCurrentNumeralLocale(): NumeralJSLocale {
  const result = (numeral as any).localeData() as NumeralJSLocale;
  return result;
}

The next major version of Angular CLI will do away with CommonJS for ng serve so this should also ameliorate the problem. This is not a real fix though, it will only reduce the symptoms.

kondi · 2018-02-16T11:19:01Z

Are you going to include chuckjaz's workaround in a release? Would be cool if we don't have to wait the webpack 4 integration and @angular/cli v6 for the real solution.

filipesilva · 2018-02-16T12:22:37Z

@kondi the workaround is in usercode, not in tooling.

kondi · 2018-02-16T13:59:48Z

Sorry, I haven't checked the repro repo and I have completely different imports which cause this. Now I understand. Thanks for the all the infos and investigation!

…

victornoel · 2018-02-21T08:17:21Z

@filipesilva @chuckjaz the workaround does not seem to be to type as any the problematic import (because it was already the case in the repro code) but it seems to be to assign the problematic line to a variable before returning it (that's really strange ^^).

matmeylan · 2018-05-24T22:07:35Z

@chuckjaz What's the workaround ? This error happens to me 1/2 times on hot reloads, making my life miserable !

Dongata · 2018-05-28T14:39:35Z

Is there any workaround available?

victornoel · 2018-05-28T14:42:35Z

@Dongata @Starscream27 read the comments : #22193 (comment)

ifdouglas-zz · 2018-06-06T20:04:13Z

For me the problem was solved just putting
declare function require(string): string;
to the top of my .ts file that has this:
const LoaderImg = require('assets/img/image.gif');

PS: TypeScript and Webpack have conflict when import an image.

kimamula · 2018-09-20T04:59:15Z

In my case, injecting REQUEST from @nguniversal/express-engine caused this problem.

import { REQUEST } from '@nguniversal/express-engine/tokens';
import { Request } from 'express';

// ...

export class AppComponent {
  constructor(@Optional() @Inject(REQUEST) req: Request) {
    // ...
  }
}

Changing the type of req to any worked for me.

export class AppComponent {
  constructor(@Optional() @Inject(REQUEST) req: any) {
    // ...
  }
}

chaoyangnz · 2019-07-22T22:43:23Z

how is this issue?

alxhub · 2020-05-28T18:42:47Z

This definitely was/is an issue, which is less of a problem now that commonjs isn't actually that common. The good news is that it's also fixed completely with Angular v9+ and Ivy.

JoostK · 2021-05-14T12:01:36Z

Closing as resolved in Ivy.

angular-automatic-lock-bot · 2021-06-14T16:11:36Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

filipesilva mentioned this issue Feb 13, 2018

ERROR in : TypeError: Cannot read property 'text' of undefined angular/angular-cli#9036

Closed

IgorMinar added the area: core Issues related to the framework runtime label Feb 13, 2018

chuckjaz added type: bug/fix freq2: medium severity3: broken labels Feb 15, 2018

ngbot bot modified the milestones: needsTriage, Backlog Feb 26, 2018

pkozlowski-opensource added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: core Issues related to the framework runtime labels Mar 14, 2020

alxhub added engine: ve state: confirmed labels May 28, 2020

jelbourn added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Oct 1, 2020

ngbot bot modified the milestones: Backlog, needsTriage Oct 1, 2020

jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Oct 1, 2020

ngbot bot modified the milestones: needsTriage, Backlog Oct 1, 2020

jelbourn added P5 The team acknowledges the request but does not plan to address it, it remains open for discussion and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity3: broken labels Oct 1, 2020

JoostK closed this as completed May 14, 2021

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compiler generates ngfactory for file with no angular metadata #22193

Compiler generates ngfactory for file with no angular metadata #22193

filipesilva commented Feb 13, 2018 •

edited

Loading

filipesilva commented Feb 13, 2018

kondi commented Feb 16, 2018

filipesilva commented Feb 16, 2018

kondi commented Feb 16, 2018 via email

victornoel commented Feb 21, 2018

matmeylan commented May 24, 2018

Dongata commented May 28, 2018

victornoel commented May 28, 2018

ifdouglas-zz commented Jun 6, 2018

kimamula commented Sep 20, 2018

chaoyangnz commented Jul 22, 2019

alxhub commented May 28, 2020

JoostK commented May 14, 2021

angular-automatic-lock-bot bot commented Jun 14, 2021

Compiler generates ngfactory for file with no angular metadata #22193

Compiler generates ngfactory for file with no angular metadata #22193

Comments

filipesilva commented Feb 13, 2018 • edited Loading

I'm submitting a...

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

Environment

filipesilva commented Feb 13, 2018

kondi commented Feb 16, 2018

filipesilva commented Feb 16, 2018

kondi commented Feb 16, 2018 via email

victornoel commented Feb 21, 2018

matmeylan commented May 24, 2018

Dongata commented May 28, 2018

victornoel commented May 28, 2018

ifdouglas-zz commented Jun 6, 2018

kimamula commented Sep 20, 2018

chaoyangnz commented Jul 22, 2019

alxhub commented May 28, 2020

JoostK commented May 14, 2021

angular-automatic-lock-bot bot commented Jun 14, 2021

filipesilva commented Feb 13, 2018 •

edited

Loading