This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix(angular.copy): support copying XML nodes #12786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good old Internet Explorer:
|
233296a
to
df0921c
Compare
Did you force-push a fix for the IE issue ? |
@@ -386,6 +386,13 @@ describe('angular', function() { | |||
expect(aCopy).toBe(aCopy.self); | |||
}); | |||
|
|||
it("should support XML nodes", function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"
--> '
? 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-) cut and paste from the original commit
@gkalpak - yes I hid my shame with a forced push. It was not really IE's fault (well yes it probably was, but it was mine too). Can you spot the mistake in my test: it("should support XML nodes", function() {
var anElement = document.createElement("foo");
var theCopy = anElement.cloneNode();
expect(copy(anElement.outerHTML)).toEqual(theCopy.outerHTML);
expect(copy(anElement)).not.toBe(anElement);
}); |
You mean besides the LGTM |
Thanks. I'll merge |
b437afb
to
122ab07
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5429