fix(@angular/cli): Fix help for generate command. #9619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
reviewed
Feb 14, 2018
| let schematicName = rawArgs[0]; | ||
| let collectionName = CliConfig.getValue('defaults.schematics.collection'); | ||
| if (!rawArgs) { | ||
| return collectionName; |
There was a problem hiding this comment.
The function seems to expect an array to be returned and from what I can tell, this will be just a single string returned.
Brocco
force-pushed
the
help-error-fix
branch
from
8f5c2da to
069acfe
Compare
Brocco
force-pushed
the
help-error-fix
branch
from
069acfe to
7ca8747
Compare
clydin
approved these changes
Feb 15, 2018
hansl
approved these changes
Feb 15, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9412