feat(@angular/cli): Ability to specify budgets for your apps #8939
Conversation
Brocco
force-pushed
the
budgets
branch
3 times, most recently
from
f9e2e54 to
4f1ae22
Compare
| }; | ||
| } | ||
| if (budget.maximumError) { | ||
| thresholds = { ...thresholds, |
There was a problem hiding this comment.
Why make a copy of thresholds instead of just adding a new property? This is confusing to read.
There was a problem hiding this comment.
Immutability habit, updated.
| } | ||
|
|
||
| budgets.map(budget => { | ||
| const thresholds = this.calcualteThresholds(budget); |
| */ | ||
| export type BudgetType = 'all' | 'allScript' | 'any' | 'anyScript' | 'bundle' | 'initial'; | ||
|
|
||
| export interface Budget { |
There was a problem hiding this comment.
Can you reuse the config .d.ts for this?
There was a problem hiding this comment.
Unfortunately, those values aren't exported separately. I could do it by hand, but when it gets regenerated it would get lost.
|
|
||
| ## NOTES | ||
|
|
||
| All sized are relative to baseline. |
There was a problem hiding this comment.
Is this a typo? It seems like this was meant to read "All sizes are relative to baseline".
Brocco
force-pushed
the
budgets
branch
2 times, most recently
from
a945c12 to
bb4be8c
Compare
Brocco
force-pushed
the
budgets
branch
3 times, most recently
from
9e2c7dd to
5e8553d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #7139