ci: re-enable windows CI [main] #30907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
try-use-ubuntu
branch
5 times, most recently
from
2d242b3 to
0c0e931
Compare
alan-agius4
force-pushed
the
try-use-ubuntu
branch
7 times, most recently
from
04726a6 to
1ceddef
Compare
angular-robot
bot
added
the
area: build & ci
alan-agius4
force-pushed
the
try-use-ubuntu
branch
from
f0566d1 to
f042f0f
Compare
alan-agius4
added
target: minor
alan-agius4
added
the
action: review
devversion
approved these changes
Aug 14, 2025
| - name: Install node modules in WSL (re-using from previous install/cache restore) | ||
| run: | | ||
| export NVM_DIR="$HOME/.nvm" | ||
| [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" |
There was a problem hiding this comment.
Interesting. Is this not installed from the bashrc?
There was a problem hiding this comment.
I tried placing them in the rc echo "[ -s \"$NVM_DIR/nvm.sh\" ] && \\. \"$NVM_DIR/nvm.sh\"" >> "$HOME/.bashrc" but I did not work.
Not sure what is wrong, I spent too much time on that and I gave up
alan-agius4
commented
Aug 14, 2025
| - name: Install node modules in WSL (re-using from previous install/cache restore) | ||
| run: | | ||
| export NVM_DIR="$HOME/.nvm" |
There was a problem hiding this comment.
This is needed to be in every step otherwise pnpm and node are not loaded.
alan-agius4
added
action: cleanup
alan-agius4
commented
Aug 14, 2025
alan-agius4
force-pushed
the
try-use-ubuntu
branch
from
f042f0f to
d0396f6
Compare
angular-robot
bot
added
the
area: build & ci
alan-agius4
force-pushed
the
try-use-ubuntu
branch
4 times, most recently
from
5cad872 to
646bcca
Compare
alan-agius4
added
action: merge
alan-agius4
force-pushed
the
try-use-ubuntu
branch
from
646bcca to
0493609
Compare
This commit fixes and re-enables windows CI. Upstream fixes: - devversion/rules_browsers#18 - angular/dev-infra#2966
alan-agius4
force-pushed
the
try-use-ubuntu
branch
from
0493609 to
f766f51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes and re-enables windows CI.
Upstream fixes: