Skip to content

refactor(@schematics/angular): remove manual install task in library schematic #30885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 12, 2025

Removes the manual NodePackageInstallTask from the library schematic. The responsibility for scheduling the installation is now delegated to the addDependency utility by passing the correct InstallBehavior.

…schematic

Removes the manual `NodePackageInstallTask` from the library schematic. The responsibility for scheduling the installation is now delegated to the `addDependency` utility by passing the correct `InstallBehavior`.

This makes the schematic cleaner and more consistent with the `application` schematic.
@clydin clydin added the target: minor This PR is targeted for the next minor release label Aug 12, 2025
@clydin clydin requested a review from alan-agius4 August 12, 2025 17:26
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 12, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 12, 2025
@alan-agius4 alan-agius4 merged commit 77e1adc into angular:main Aug 12, 2025
33 checks passed
@clydin clydin deleted the schematics/library-install-cleanup branch August 12, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants