-
Notifications
You must be signed in to change notification settings - Fork 11.9k
Update Prettier defaults to enforce single quotes and 100 character line width #30882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Hi maintainers, this PR is ready for review. Could you please assign reviewers? |
@suhasrk Can you reword the commit message to follow the commit message format? This is necessary for automatic changelog generation and semver tracking purposes. |
You can see an example commit messasge in the previous change to the file: 4221a33 |
Sure. I will do and notify here once checks are passed |
@jkrems Can you please review now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this happen! 🎉
@jkrems |
Created a squash & rebase here: #30884 (We use automated tooling that assumes the commits can land as-is and I don't have access to modify branches from PRs.) |
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, the prettier block in package.json does not fully align with Angular’s recommended defaults as defined in .editorconfig.
This can lead to inconsistent formatting across projects, as common preferences like "singleQuote": true and "printWidth": 100 are not enforced in Prettier, even though .editorconfig specifies similar rules.
Issue Number: #30744
What is the new behavior?
The prettier block in package.json has been updated to include Angular’s recommended defaults (singleQuote: true, printWidth: 100), ensuring consistency between .editorconfig and Prettier formatting across all projects.
Does this PR introduce a breaking change?
Other information
This change avoids manual intervention in minimal projects while preserving the intended HTML formatting benefits for standard projects.