Skip to content

fix(@angular/pwa): remove background_color and theme_color from manifest #30339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

alan-agius4
Copy link
Collaborator

These properties are unnecessary and create additional maintenance overhead for developers.

Closes: #30336

…anifest

These properties are unnecessary and create additional maintenance overhead for developers.

Closes: angular#30336
@alan-agius4 alan-agius4 requested a review from clydin May 19, 2025 08:44
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 19, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 19, 2025
@alan-agius4 alan-agius4 merged commit 7a21deb into angular:main May 19, 2025
34 checks passed
@alan-agius4 alan-agius4 deleted the colors-pwa branch May 19, 2025 12:37
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.2.x, 20.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/pwa target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@angular/pwa: Consider necessity of defaulting to the specific theme-color #1976d2
2 participants