Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: provide i18nDuplicateTranslation config value to checkDuplicateMessages function #29179

Conversation

Algoritm211
Copy link
Contributor

@Algoritm211 Algoritm211 commented Dec 18, 2024

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Current behaviour is described inside this issue - #23635

Issue Number: #23635

What is the new behavior?

Now we can add different values according to the i18nDuplicateTranslation option

i18nDuplicateTranslation?: I18NTranslation;
and have corresponding output, not hardcoded warning

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

google-cla bot commented Dec 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Dec 18, 2024
@Algoritm211 Algoritm211 changed the title feat: provide i18nDuplicateTranslation config value to checkDuplicateMessages function bugfix: provide i18nDuplicateTranslation config value to checkDuplicateMessages function Dec 18, 2024
@alan-agius4 alan-agius4 requested a review from clydin March 5, 2025 18:09
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker merge: squash commits When the PR is merged, a squash and merge should be performed merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release labels Mar 5, 2025
@alan-agius4 alan-agius4 merged commit b100c71 into angular:main Mar 5, 2025
13 checks passed
@alan-agius4
Copy link
Collaborator

The changes were merged into the following branches: main, 19.2.x

alan-agius4 pushed a commit that referenced this pull request Mar 5, 2025
`i18nDuplicateTranslation` config value (#29179)

This fixes an issue where the config was not passed.

Closes #23635

(cherry picked from commit b100c71)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed merge: squash commits When the PR is merged, a squash and merge should be performed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants