Skip to content

fix(@angular-devkit/build-angular): handle regular expressions in proxy config when using Vite #26972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

alan-agius4
Copy link
Collaborator

This commit enables proxies to have a RegExp as context when using Vite. See: https://vitejs.dev/config/server-options#server-proxy

Closes #26970

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 26, 2024
@alan-agius4 alan-agius4 requested a review from clydin January 26, 2024 13:21
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/build-angular): do not process regular expressions in proxy config when using Vite fix(@angular-devkit/build-angular): handle regular expressions in proxy config when using Vite Jan 26, 2024
…xy config when using Vite

This commit enables proxies to have a RegExp as context when using Vite. See: https://vitejs.dev/config/server-options#server-proxy

Closes angular#26970
This commit removes repetitive code in the mentioned spec file.
@alan-agius4 alan-agius4 deleted the regexp-proxy branch January 26, 2024 14:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular CLI messes up proxy.conf.js regex proxy -settings passed to Vite when using esbuild
1 participant