Skip to content

fix(@angular-devkit/build-angular): media files download files in vite #26218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Nov 3, 2023

Unlike assets, output file were not prefixed with a /. This change alings these and now files are always prefixed with a slash.

Closes #26215

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Nov 3, 2023
@alan-agius4 alan-agius4 requested a review from clydin November 3, 2023 09:35
@alan-agius4 alan-agius4 modified the milestones: needsTriage, v17 Nov 3, 2023
@alan-agius4 alan-agius4 force-pushed the load-media-error branch 4 times, most recently from 244032a to 95efb7e Compare November 3, 2023 13:43
Unlike assets, output file were not prefixed with a `/`. This change alings these and now files are always prefixed with a slash.

Closes angular#26215
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 3, 2023
@alan-agius4 alan-agius4 merged commit 8c76cb2 into angular:main Nov 3, 2023
@alan-agius4 alan-agius4 deleted the load-media-error branch November 3, 2023 15:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

application builder: font download failing
2 participants