refactor(@angular-devkit/build-angular): simplify how specs are found and loaded #23939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
test-specs-entrypoint
branch
3 times, most recently
from
0e2c0a5 to
375c0f8
Compare
alan-agius4
added
action: review
alan-agius4
force-pushed
the
test-specs-entrypoint
branch
from
375c0f8 to
7b7c0cb
Compare
clydin
reviewed
Sep 23, 2022
packages/angular_devkit/build_angular/src/builders/karma/index.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/webpack/plugins/karma/karma.ts
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/builders/karma/find-tests-plugin.ts
Outdated
Show resolved
Hide resolved
… and loaded Prior to this change specs where found and loaded using Webpack's `require.context` API. The `require.context` is found in the users project `test.ts`. This resulted in a complex and hacky setup especially to filter tests when the `include` builder option is provided, were we had to amend the `test.ts` in memory. With this change we find all the specs files and add them as part of the main entrypoint. Closes angular#23751 and closes angular#22531
alan-agius4
force-pushed
the
test-specs-entrypoint
branch
from
7b7c0cb to
71d136f
Compare
clydin
approved these changes
Sep 23, 2022
clydin
added
action: merge
|
Is it possible to backport this to the 14 branch so we can consume the fix to #23751? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change specs where found and loaded using Webpack's
require.contextAPI. Therequire.contextis found in the users projecttest.ts. This resulted in a complex and hacky setup especially to filter tests when theincludebuilder option is provided, were we had to amend thetest.tsin memory.With this change we find all the specs files and add them as part of the main entrypoint.
Closes #23751 and closes #22531